Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate usage of the PEACH API #25

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion supporting_files/ArrayExpressSiteConfig.yml.default
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ AUTOSUBS_CURATOR_EMAIL: [email protected]

HTTP_PROXY:

AE_ARRAYDESIGN_LIST: 'http://peach.ebi.ac.uk:8480/api/all-arrays.txt'
AE_ARRAYDESIGN_LIST: 'http://codon-plantain-01:8480/arrays'

MAX_LWP_DOWNLOAD: 10104857600

Expand Down
8 changes: 4 additions & 4 deletions supporting_files/AtlasSiteConfig.yml.default
Original file line number Diff line number Diff line change
Expand Up @@ -87,11 +87,11 @@ atlas_curated_accessions_file: atlas_curated_accessions.yml
# File containing accessions of experiments that don't have R experiment summaries.
no_r_data_accessions_file: no_r_object

# URL to get ADF info from ArrayExpress.
arrayexpress_adf_info_url: http://peach.ebi.ac.uk:8480/api/array.txt?acc=
# URL to get ADF info from ArrayExpress. Replace URL because PEACH has been deprecated.
arrayexpress_adf_info_url: http://codon-plantain-01:8480/arrays?acc=

# URL to get privacy info from ArrayExpress
arrayexpress_privacy_info_url: http://peach.ebi.ac.uk:8480/api/privacy.txt?acc=
# URL to get privacy info from ArrayExpress.
arrayexpress_privacy_info_url: https://www.ebi.ac.uk/biostudies/api/v1/search?type=study&accession=
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you know, this new query is going to return the result in JSON format.

It would be great to double-check that where arrayexpress_privacy_info_url is used, it is fine with getting the result in json

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The arrayexpress_privacy_info_url and arrayexpress_adf_info_url variables don't seem to be used in any of our Gitlab and Github repos (other than here, where they are defined). Perhaps these are used in files that are not in a repo (or replaced and are no longer in use). I checked with the curators, but they also don't know where these variables are used.


# Script for getting iRAP single-lib results.
#isl_results_script: sw/islinstall_prod/isl/db/scripts/findCRAMFiles.sh
Expand Down