Deprecate usage of the PEACH API #25
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmb59
approved these changes
Apr 6, 2023
There was a problem hiding this comment.
@irisdianauy LGTM, as long as
- the CI passes tests
- you consider my comment regarding the new format for
arrayexpress_privacy_info_url
| # URL to get privacy info from ArrayExpress | ||
| arrayexpress_privacy_info_url: http://peach.ebi.ac.uk:8480/api/privacy.txt?acc= | ||
| # URL to get privacy info from ArrayExpress. | ||
| arrayexpress_privacy_info_url: https://www.ebi.ac.uk/biostudies/api/v1/search?type=study&accession= |
There was a problem hiding this comment.
As you know, this new query is going to return the result in JSON format.
It would be great to double-check that where arrayexpress_privacy_info_url is used, it is fine with getting the result in json
There was a problem hiding this comment.
The arrayexpress_privacy_info_url and arrayexpress_adf_info_url variables don't seem to be used in any of our Gitlab and Github repos (other than here, where they are defined). Perhaps these are used in files that are not in a repo (or replaced and are no longer in use). I checked with the curators, but they also don't know where these variables are used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes here will replace or remove the usage of the PEACH API.