-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add library-wise logic to atlas-fastq-provider wrapper #262
Conversation
… what the downstream IRAP tool requires
@pcm32 We need to bump atlas-fastq-provider to 0.4.3 and deploy in a new conda version before this will work. Also we might need to add:
|
I guess we are waiting for the bump here, correct? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments to improve this.
@pmb59 and @irisdianauy can you please add couple of tests utilising |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @irisdianauy and @anilthanki As all requests by @pcm32 are done, we are ready to merge. |
Description
Make some refinements to the atlas-fastq-provider galaxy wrapper. ISL uses the library-wise downloader rather than file-wise, we need an extra option in the wrapper for that.
Basically, the wrapper needs a library-wise logic that calls
fetchEnaLibraryFastqs.sh
(if library-name param is provided) orfetchFastq.sh
(if filename param is provided). Depending on each case, specific set of parameters need to be displayed.This PR is related to ebi-gene-expression-group/atlas-fastq-provider#17
Fixes # (issue)
Type of change
Checklist
@TOOL_VERSION@
), then I have reset all 'build' values to 0 (e.g.@TOOL_VERSION@+galaxy0
)@TOOL_VERSION@+galaxy0
@TOOL_VERSION@+galaxy1
)