Andrew/app refactor #198
Closed
Andrew/app refactor #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 65a2d73.
This reverts commit 100943c.
Wanted to use scoped reference counter but enjoy this very recent bug: https://issues.chromium.org/issues/349207015 Since the object lives for the entire length of the program, it seems like raw_ptr woudl be acceptable.
|
Lots of code here had to be erased #200 is more concise |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closed as was doseleted in later work
see this diff instead.
It may be better to PR this into the build_overhaul branch instead of master
Summary
This rewrites the C++ section of kaleido to use the only available api, DevTools, while organizing a bit over that layer to use properly chromium's build system, initialization procedures, and concurrency model.
Please refer to the upcoming documentation for a guided tour.