Andrew/interface fix #200
Open
Andrew/interface fix #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change name to refect increased scope, will try to run whole gn process
Since I'm not intending to support 88 or 108, I just use the 126 tag DEPs from src/headless/app as a template. But if you wanted to try and build these, you'd retrieve the DEPS file from the same directory but at the right git checkout.
Closed
This reverts commit 37e4ddf.
gvwilson
added
community
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reflects all of the changes made to kaleido in the fix. See closed, obsolete #198
There are three more small PRs that will come on top of this:
windows_fix
max_fix
pdf_fix