Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Andrew/app refactor #198

Closed
wants to merge 268 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
268 commits
Select commit Hold shift + click to select a range
3935971
Add script to find architecture
ayjayt Jul 3, 2024
dc600cf
Reorganize utilities to support platform switch
ayjayt Jul 3, 2024
1d7acc9
Remove filters from circle ci
ayjayt Jul 3, 2024
6249077
Add line to delete depot_tools/.git
ayjayt Jul 3, 2024
bd31520
Archive old config.yml and write simple one
ayjayt Jul 3, 2024
00d58b3
Upgrade resource class, small doesn't exist
ayjayt Jul 3, 2024
3a1b09e
Remove resource class
ayjayt Jul 3, 2024
603b450
Updated config.yml
ayjayt Jul 3, 2024
5039c71
Use more modern ubuntu for ci
ayjayt Jul 3, 2024
6f43d61
Switch to default linux imagine for circleci
ayjayt Jul 3, 2024
7a7e89d
Print out some diagnostics
ayjayt Jul 3, 2024
1e9056a
Print out some diagnostics 2
ayjayt Jul 3, 2024
ddf8b6e
Fix bad line order cause false error
ayjayt Jul 3, 2024
e262593
Allow multi-platform builds
ayjayt Jul 3, 2024
d756fd6
Add windows box
ayjayt Jul 3, 2024
f395942
Remove redundant dep install
ayjayt Jul 3, 2024
84f636f
Add option to delete git
ayjayt Jul 3, 2024
504fbf0
Add mac CI
ayjayt Jul 3, 2024
46a3647
Remove resource class from win circleci
ayjayt Jul 3, 2024
52f2433
Remove long-runing delete process from mac
ayjayt Jul 3, 2024
46ff12c
Fix yaml syntax
ayjayt Jul 3, 2024
c06ee97
Add utility to put build scripts in bin
ayjayt Jul 3, 2024
c3c5b7b
Add to git file from previous commit
ayjayt Jul 3, 2024
a04fc56
Add cheap linux build
ayjayt Jul 3, 2024
11c6298
Fix yaml
ayjayt Jul 3, 2024
c67d9c2
Add version to python
ayjayt Jul 3, 2024
7f99d5c
Remove debugging print
ayjayt Jul 3, 2024
f058851
Reformat comments a bit
ayjayt Jul 4, 2024
aba2d65
Reorganize dev interface a bit
ayjayt Jul 6, 2024
1e90824
Create defaults for build
ayjayt Jul 6, 2024
6e4613b
Add script to run all
ayjayt Jul 6, 2024
d9ef495
Update toolchain/README.md
ayjayt Jul 6, 2024
d445b6d
Improve build template
ayjayt Jul 6, 2024
d2299f9
Add path modifications to utilties for all plats
ayjayt Jul 6, 2024
7003656
Add build artifact to gitignore
ayjayt Jul 6, 2024
0232303
Fix up circle ci
ayjayt Jul 6, 2024
55639bc
Create docker helper script + init_tools start
ayjayt Jul 6, 2024
ed755d0
Rename stages-->src + add new to bin
ayjayt Jul 6, 2024
55f047f
Organize folders a bit more
ayjayt Jul 6, 2024
aa8d23b
Bring vendor tools to vendor, not repo
ayjayt Jul 6, 2024
d68c115
Copy some host env to docker env for ease
ayjayt Jul 7, 2024
a41d281
Rework docker build a bit:
ayjayt Jul 8, 2024
f49e66b
Add krefresh command to do clean build
ayjayt Jul 8, 2024
ab416ac
Fix up verbose
ayjayt Jul 8, 2024
c3c1457
Add usage to two scripts
ayjayt Jul 8, 2024
2542475
Cache apt-get update
ayjayt Jul 8, 2024
1909b7a
Add .gitconfig to docker user
ayjayt Jul 8, 2024
3802da9
Improve kdocker help
ayjayt Jul 8, 2024
ccb8f36
Rework and comment utilities a bit
ayjayt Jul 9, 2024
2f44697
Refactor build strategy
ayjayt Jul 10, 2024
fe4fe4a
Add some more flag syntax
ayjayt Jul 10, 2024
46a86ad
Fix bools in all/
ayjayt Jul 10, 2024
cc3d9a5
Fix some typos
ayjayt Jul 10, 2024
fbb50cb
Fix up bad logic
ayjayt Jul 10, 2024
2107d1b
Fix bad logic
ayjayt Jul 10, 2024
d907535
Fix main_repo
ayjayt Jul 10, 2024
99e567a
Fix logic in all
ayjayt Jul 10, 2024
e9c5b36
Fix env var typo
ayjayt Jul 10, 2024
c4f64fa
Tune make_bin to work with zsh
ayjayt Jul 11, 2024
5ba9595
Skip all automatic sourcing
ayjayt Jul 11, 2024
9c095d2
Upgrade to new version of chromium:
ayjayt Jul 11, 2024
3e3c315
Pull out krefresh and add --toolchain
ayjayt Jul 11, 2024
4ca9346
Leverage git for refresh, not cp
ayjayt Jul 11, 2024
1f69dde
Allow empty patches
ayjayt Jul 11, 2024
5f1c769
Remove comment
ayjayt Jul 11, 2024
4595cb1
Fix up a bit bash outputs
ayjayt Jul 11, 2024
134f3f2
List unrefreshed files
ayjayt Jul 11, 2024
d4ca1d5
Add depot_tools to git ignore
ayjayt Jul 11, 2024
530051d
Fix typo in init_tools
ayjayt Jul 11, 2024
f159d3b
Make python build executable
ayjayt Jul 11, 2024
d2336a9
Make install-build-deps noninteractive
ayjayt Jul 11, 2024
58530b7
Fix up verbosity
ayjayt Jul 11, 2024
9e9b8da
Create 03-ksync
ayjayt Jul 11, 2024
a6588b9
Remove OS-switches from ksync
ayjayt Jul 11, 2024
d026a8f
Fix bad logic
ayjayt Jul 11, 2024
e2bdb9e
Add windows build step NOTES for sync
ayjayt Jul 11, 2024
07fb2db
Fix comment in ksync
ayjayt Jul 15, 2024
c19dddc
Add patch_chromium build step
ayjayt Jul 16, 2024
eb7a4f9
Add no py3 flag to old versions
ayjayt Jul 16, 2024
9919068
Remove historical readme
ayjayt Jul 16, 2024
854c428
Add verbose flag to gsync
ayjayt Jul 16, 2024
0d53787
Use git patch instead of cp for patching
ayjayt Jul 16, 2024
d3cd9f5
Add gen_preamble to build tools
ayjayt Jul 16, 2024
49f91e7
Make 04/05 executable
ayjayt Jul 16, 2024
c7bdb2b
Remember to set version env vars
ayjayt Jul 16, 2024
42b5cb3
Copy 108 patches to 126
ayjayt Jul 16, 2024
cbf81fb
Fix silly typo
ayjayt Jul 16, 2024
c034858
Fix silly typo2
ayjayt Jul 16, 2024
6e7bf60
Fix patch, try w/o patches for 126
ayjayt Jul 16, 2024
fd53884
Update README.md
ayjayt Jul 16, 2024
5551fcc
Update gitignore to reflect directory changes
ayjayt Jul 16, 2024
c8f2e10
Move kaleido from repos/ to src/
ayjayt Jul 16, 2024
aa3d187
Fix slash direction
ayjayt Jul 16, 2024
f6f721a
Fix slash direction2
ayjayt Jul 16, 2024
d310691
Reorg gitignore
ayjayt Jul 16, 2024
e49687b
Add 06, append gn directives
ayjayt Jul 16, 2024
81f920d
Add platform swtich to 06-append_gn
ayjayt Jul 16, 2024
2686b39
Remove old build system
ayjayt Jul 16, 2024
9169ebc
Move patches to src/vendor-patches
ayjayt Jul 16, 2024
72ab5ce
Add more gn stuff to append_gn, change name:
ayjayt Jul 16, 2024
733495e
Remove host-arch detect, unnecessary
ayjayt Jul 16, 2024
167635f
Finish ninja gn build
ayjayt Jul 16, 2024
6fbb28f
Reorg gn-ninja fragments
ayjayt Jul 16, 2024
593abab
Update .gitignore
ayjayt Jul 16, 2024
8d97e34
Fix typo in gitignore
ayjayt Jul 16, 2024
d6c2be8
Set chmod 06-* +x
ayjayt Jul 16, 2024
aafb633
Fix syntax typo
ayjayt Jul 16, 2024
663ef20
Add cd to gen out per gn error
ayjayt Jul 16, 2024
56c32c1
Add quotes to gn arg file
ayjayt Jul 16, 2024
8e9037f
Create 07-write_kversion
ayjayt Jul 16, 2024
2370da0
Fix typos in xx-all.sh
ayjayt Jul 16, 2024
ee0752b
Add debug info to version py
ayjayt Jul 16, 2024
0fdb870
Fix path semantics in version.py
ayjayt Jul 16, 2024
9748ae2
Revert subtle change to version.py
ayjayt Jul 16, 2024
369bff8
Remove vestigal flag from 07
ayjayt Jul 16, 2024
2dfddd1
Rework c++ naming and add 08-sync_cpp
ayjayt Jul 16, 2024
9fa8a8b
Change 04-patch to precheck for patches in dir
ayjayt Jul 16, 2024
851a15d
Add DEPS template to all versions:
ayjayt Jul 16, 2024
4401b42
Add 09-build_kaleido
ayjayt Jul 16, 2024
78b3ba1
Add BUILD.gn.patch to all platforms
ayjayt Jul 16, 2024
0f19e30
Fix typo in dir name
ayjayt Jul 16, 2024
3783fc7
Remove unnecessary deps from gn_append
ayjayt Jul 16, 2024
dc11d0a
Replace 126 kaleido w/ headless exampel app
ayjayt Jul 16, 2024
5a12666
Change gn_append.patch
ayjayt Jul 16, 2024
96c1558
Continue even if gn patch applied
ayjayt Jul 16, 2024
3361aae
Fix continue semantics
ayjayt Jul 16, 2024
1a7531d
Fix continue semantics2
ayjayt Jul 16, 2024
6733ade
Remove official_build flag
ayjayt Jul 16, 2024
b55b7ee
Fix up gn_args template
ayjayt Jul 16, 2024
a5ea075
Fix syntax error '-->"
ayjayt Jul 16, 2024
d94ccfe
Refix example port to proper naming
ayjayt Jul 16, 2024
c0d5dc1
Follow example for BUILD.gn more closely
ayjayt Jul 16, 2024
1690366
Ammend gn build to remove weird flag
ayjayt Jul 16, 2024
522a560
Rework ninja build
ayjayt Jul 16, 2024
7ca0bcb
Fix boolean logic error
ayjayt Jul 16, 2024
ea7b9aa
Remove weird build artifacts
ayjayt Jul 16, 2024
ec7b90a
Remove weird build artifacts2 w/ typo
ayjayt Jul 16, 2024
e38eb0e
Improve verbosity of build ninja
ayjayt Jul 16, 2024
00a6631
Fix BUILD.gn for version
ayjayt Jul 16, 2024
8e10fb0
Try process sub to not eat my own tail
ayjayt Jul 17, 2024
562112f
Try sed for truncate
ayjayt Jul 17, 2024
e5775df
Use tempfile, not sed
ayjayt Jul 17, 2024
ef5ea78
Add verbosity
ayjayt Jul 17, 2024
c5ecde1
Make ninja build versiond dependent
ayjayt Jul 17, 2024
fc5ef6e
Refactor build a bit:
ayjayt Jul 17, 2024
6f4691b
Remove unneeded todos
ayjayt Jul 17, 2024
972bf6e
Add rsync as docker/image dependency
ayjayt Jul 17, 2024
726e57b
Make own copy of headless lib to be kaleido lib
ayjayt Jul 17, 2024
2e2f588
Create kaleido base for sanity testing structure
ayjayt Jul 17, 2024
f78771f
Add more info to 06 help
ayjayt Jul 17, 2024
32d18c7
Merge branch 'andrew/build_overhaul' into andrew/app_refactor
ayjayt Jul 17, 2024
358c272
Enable kaleido_lib
ayjayt Jul 17, 2024
c63979e
Write optimistic paths into TRY
ayjayt Jul 17, 2024
faaf034
Merge branch 'andrew/build_overhaul' into andrew/app_refactor
ayjayt Jul 17, 2024
02a48e8
Fix syntax typo
ayjayt Jul 17, 2024
dc0f464
Merge branch 'andrew/build_overhaul' into andrew/app_refactor
ayjayt Jul 17, 2024
e0fc277
Reorder to set variable properly
ayjayt Jul 17, 2024
37096c2
Merge branch 'andrew/build_overhaul' into andrew/app_refactor
ayjayt Jul 17, 2024
9b0acfb
Reorder to set variable properly2
ayjayt Jul 17, 2024
29814c7
Merge branch 'andrew/build_overhaul' into andrew/app_refactor
ayjayt Jul 17, 2024
52f12e3
Add missing ;
ayjayt Jul 17, 2024
cfa7ffe
Uncomment some boilerplate
ayjayt Jul 17, 2024
77d71d4
Fix syntax error w/ macro
ayjayt Jul 17, 2024
7b5a2e5
Add more comments
ayjayt Jul 17, 2024
d90050e
Reorganize namespaces
ayjayt Jul 17, 2024
0a2d1ed
Add logic to process command line
ayjayt Jul 17, 2024
2d294f5
Add some CLI includes
ayjayt Jul 17, 2024
ae87419
Add some CLI includes2
ayjayt Jul 17, 2024
0cfb9ca
Remove check for process flag from example
ayjayt Jul 17, 2024
496cdb1
Add failure as test
ayjayt Jul 17, 2024
0512551
Dump flags for info
ayjayt Jul 17, 2024
d54bcd4
Log commandline information
ayjayt Jul 17, 2024
ad0853e
Organize switches
ayjayt Jul 17, 2024
e55d370
Add comment about processing commandline
ayjayt Jul 17, 2024
ac0c2ca
Add notes about parameters
ayjayt Jul 17, 2024
2878b49
Remove irrelevant part of examples
ayjayt Jul 17, 2024
2d5d1c0
Strip more unnecessary out of example
ayjayt Jul 17, 2024
c9f3d25
Remove more unnecesary parts of example
ayjayt Jul 17, 2024
8ce36f3
Improve comments
ayjayt Jul 17, 2024
69d95ca
Shim out kaleido class
ayjayt Jul 17, 2024
e4a56f6
Add deps for Browser
ayjayt Jul 17, 2024
8c083e8
Introduce HeadlessBrowser into k namespace
ayjayt Jul 17, 2024
ab7d3a8
Move headless back out
ayjayt Jul 17, 2024
c77ce0a
Start browser
ayjayt Jul 17, 2024
56b625e
Fix capitalization typo
ayjayt Jul 17, 2024
798fc91
Declare class Kaleido in .h
ayjayt Jul 17, 2024
09ba9df
Reorder class declaration to avoid incomplete type
ayjayt Jul 17, 2024
d73e503
Finish callback definition
ayjayt Jul 17, 2024
35fc0a3
Fix namespace typos
ayjayt Jul 17, 2024
f77ab3c
Readd some process type switches
ayjayt Jul 17, 2024
7b06bea
Add destructors
ayjayt Jul 17, 2024
6edeeba
Restore IS_WIN buildflag
ayjayt Jul 17, 2024
47a445b
Move main to app.cc
ayjayt Jul 17, 2024
0cef37d
Move boiler plate into app.cc
ayjayt Jul 17, 2024
ad80c1c
Revert "Move boiler plate into app.cc"
ayjayt Jul 17, 2024
d110973
Revert "Move main to app.cc"
ayjayt Jul 17, 2024
bb25649
Fix macro typo
ayjayt Jul 17, 2024
d43efe8
Factor boilerplate into kaleido_main.cc:
ayjayt Jul 17, 2024
a78e288
Factor our commandline processing
ayjayt Jul 17, 2024
c1869e0
Move app into kaleido_main.cc
ayjayt Jul 17, 2024
20778e1
Add notes and indentation
ayjayt Jul 17, 2024
9772cd6
Make namespaced calls more readable
ayjayt Jul 17, 2024
4ede0a7
Fix verbose flag in build
ayjayt Jul 17, 2024
70fc330
Merge branch 'andrew/build_overhaul' into andrew/app_refactor
ayjayt Jul 17, 2024
46b7b39
Fix verbose in ksync
ayjayt Jul 17, 2024
d20d0ae
Merge branch 'andrew/build_overhaul' into andrew/app_refactor
ayjayt Jul 17, 2024
1fa35a7
Add basic JSON interpreter
ayjayt Jul 17, 2024
d8b6268
Reorganized a but, comments, tabs, interfaces
ayjayt Jul 18, 2024
45b9159
Add missing ;
ayjayt Jul 18, 2024
7d7963f
Lambdas terminate in ;
ayjayt Jul 18, 2024
b896a12
Add namespace to devtools clients
ayjayt Jul 18, 2024
2712d14
Fix typo in namespace
ayjayt Jul 18, 2024
7e61ed7
Move header to correct file
ayjayt Jul 18, 2024
e9b17bd
Set defaults explicitly per chromium request
ayjayt Jul 18, 2024
a001619
Fix some syntax typos
ayjayt Jul 18, 2024
e0f44cf
Remove lambda function as base::bind lacks support
ayjayt Jul 18, 2024
cb55bae
Remove inline marker- chromum complains
ayjayt Jul 19, 2024
ef2ab0a
Create dispatch subclass shim:
ayjayt Jul 19, 2024
4bee382
Add task runner to dispatch
ayjayt Jul 19, 2024
fa7371d
Add queue and shim for posting tasks
ayjayt Jul 19, 2024
3e4065a
Fix up control flow of initialization
ayjayt Jul 19, 2024
ea5002d
Build first createTab method
ayjayt Jul 19, 2024
329e735
Add notes from 2 hours of work
ayjayt Jul 19, 2024
7124e57
Save work
ayjayt Jul 19, 2024
65a2d73
Remove concurrency
ayjayt Jul 19, 2024
100943c
Revert "Remove concurrency"
ayjayt Jul 19, 2024
c0fb9db
Revert "Revert "Remove concurrency""
ayjayt Jul 19, 2024
c3462fc
Use devtools to open a tab
ayjayt Jul 19, 2024
97b3851
Finish 4 task for createTab- store
ayjayt Jul 19, 2024
8f1cd72
Make note of strategies
ayjayt Jul 19, 2024
cd1cef9
Make basic error handling for JSON input
ayjayt Jul 19, 2024
60ad345
Fix some naming and syntax bugs
ayjayt Jul 19, 2024
c7821f2
Rectify destructor to prevent segfault
ayjayt Jul 19, 2024
97eeabc
Add ID to dispatch operations
ayjayt Jul 19, 2024
53e35f7
Switch from unordered set to unordered map
ayjayt Jul 19, 2024
cd6a589
Add kaleido as parent_ in Dispatch
ayjayt Jul 19, 2024
a45be24
Make dispatch raw_ptr and remove destructor
ayjayt Jul 19, 2024
05a18a3
Add error handling
ayjayt Jul 19, 2024
8709d5d
Add raw archive descriptions
ayjayt Jul 20, 2024
cc65416
Add utility for understanding archive situation
ayjayt Jul 20, 2024
a2b4267
Add tooling to 10-extract
ayjayt Jul 21, 2024
f0d1309
Format extract output for automatic consumption
ayjayt Jul 21, 2024
209a850
Execute extract function and add to xx-all
ayjayt Jul 21, 2024
d069f9a
Remove debug print
ayjayt Jul 21, 2024
024419a
Add metadata to 10-extract
ayjayt Jul 21, 2024
f28ebe4
Fix mathjax copy
ayjayt Jul 21, 2024
1aca1cb
Add 11-build-js.sh command
ayjayt Jul 21, 2024
293ba4e
Add more build artifacts to .gitignore
ayjayt Jul 21, 2024
fdd099d
Fix MathJax --> Mathjax
ayjayt Jul 21, 2024
a9133b1
Set up deps for nodejs work
ayjayt Jul 21, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
424 changes: 49 additions & 375 deletions .circleci/config.yml

Large diffs are not rendered by default.

416 changes: 416 additions & 0 deletions .circleci/config.yml.old

Large diffs are not rendered by default.

54 changes: 25 additions & 29 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,32 +1,28 @@
repos/CREDITS.html
repos/src
repos/depot_tools
*.DS_Store
*.kate-swp
repos/.cipd/
repos/.gclient_entries
repos/.idea
repos/build
repos/cmake-build-debug
repos/kaleido/js/node_modules
repos/kaleido/js/build
repos/kaleido/version
repos/kaleido/LICENSE.txt
repos/kaleido/README.md
repos/kaleido/py/LICENSE.txt
repos/kaleido/py/README.md
repos/kaleido/py/tests/baselines/plotly/failed
repos/kaleido/artifacts
repos/kaleido/kaleido_artifacts*.zip
# Py build stuff
*.pyc
win_toolchain/*.zip
repos/kaleido/py/kaleido/executable
repos/kaleido/py/kaleido/_version.py
repos/kaleido/py/build/
repos/kaleido/py/dist/
*.egg-info/
repos/kaleido/py/scratch/
.idea/
repos/CREDITS.html
repos/*.tar.gz

# Text editor stuff
*.DS_Store
*.kate-swp
*.sw*

# Old, don't know
.idea/

# Toolchain artifacts
.set_version
bin
toolchain/tmp/

# Vendor repos
vendor/src
vendor/depot_tools

# Build artifacts
build/
src/kaleido/LICENSE.txt
src/kaleido/README.md
src/kaleido/CREDITS.html
src/kaleido/version
CREDITS.html
206 changes: 0 additions & 206 deletions README-HISTORICAL.md

This file was deleted.

4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
# Overview
Kaleido is a cross-platform library for generating static images (e.g. png, svg, pdf, etc.) for web-based visualization libraries.
Kaleido is a cross-platform library for generating static images (e.g. png, svg, pdf, etc.) for web-based visualization libraries.

In short: If you `pip install kaleido` you can use `fig.write_image("filename.png")`.

It is designed to be relatively straight-forward to extend to other web-based visualization libraries (and other programming languages)- see [BUILD_AND_RELEASE.md](BUILD_AND_RELEASE.md) for that and other developer questions.
It is designed to be relatively straight-forward to extend to other web-based visualization libraries (and other programming languages)- see [BUILD_AND_RELEASE.md](toolchain/BUILD_AND_RELEASE.md) for that and other developer questions.

[Here is the historical readme](README-HISTORICAL.md)

Expand Down
10 changes: 0 additions & 10 deletions repos/CMakeLists.txt

This file was deleted.

60 changes: 0 additions & 60 deletions repos/linux_scripts/Dockerfile

This file was deleted.

Loading