-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: fix incorrectly using the schema for plan cache #57964
planner: fix incorrectly using the schema for plan cache #57964
Conversation
Signed-off-by: wjhuang2016 <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #57964 +/- ##
================================================
+ Coverage 73.1421% 74.7843% +1.6422%
================================================
Files 1671 1719 +48
Lines 460703 475114 +14411
================================================
+ Hits 336968 355311 +18343
+ Misses 102998 97476 -5522
- Partials 20737 22327 +1590
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: wjhuang2016 <[email protected]>
Signed-off-by: wjhuang2016 <[email protected]>
Signed-off-by: wjhuang2016 <[email protected]>
Signed-off-by: wjhuang2016 <[email protected]>
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qw4990, tangenta, zimulala The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/run-cherry-picker release-8.5 |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
What problem does this PR solve?
Issue Number: close #56733
Problem Summary:
If the table ID is changed for a given table name, the plan cache key is not updated.
For an insert statement, it may use the outdated schema, resulting in incorrect data or query results.
What changed and how does it work?
Make sure the
tbl
is updated in function planCachePreprocess() if tableByID doesn't return the table info.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.