-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: simplify TestMDLPreparePlanCacheExecuteInsert #58113
Conversation
Hi @D3Hunter. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@@ -0,0 +1 @@ | |||
7.4.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bazel 8.0.0 just released today, The WORKSPACE file is disabled by default, so fix the version temporarily
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tangenta, wjhuang2016 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #58113 +/- ##
================================================
+ Coverage 73.1496% 74.9094% +1.7598%
================================================
Files 1675 1720 +45
Lines 461848 470002 +8154
================================================
+ Hits 337840 352076 +14236
+ Misses 103258 95751 -7507
- Partials 20750 22175 +1425
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: ref #56733
Problem Summary:
What changed and how does it work?
TestMDLPreparePlanCacheExecuteInsert is introduced in #57964, but the case is quite complex, harder to know which statement causes the issue
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.