table: fix the issue that the default value for BIT column is wrong | tidb-test=pr/2424

[YangKeao]

What problem does this PR solve?

Issue Number: close #57301, close #57312

Problem Summary:

1. The CREATE TABLE statement didn't assert whether the default value for BIT is valid.
2. The default value for BIT column is casted multiple times and may cause unexpected behavior.

What changed and how does it work?

1. Revert part of types: convert string to MySQL BIT correctly #21310
2. Validate the length of BIT default value.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[codecov]

Codecov Report

Attention: Patch coverage is 57.14286% with 6 lines in your changes missing coverage. Please review.

Project coverage is 74.6925%. Comparing base (6528da5) to head (ca270ca).
Report is 23 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #57303        +/-   ##
================================================
+ Coverage   72.9071%   74.6925%   +1.7854%     
================================================
  Files          1667       1714        +47     
  Lines        460833     469996      +9163     
================================================
+ Hits         335980     351052     +15072     
+ Misses       104199      96919      -7280     
- Partials      20654      22025      +1371     

Flag	Coverage Δ
integration	49.1879% <57.1428%> (?)
unit	72.2852% <35.7142%> (-0.0103%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	52.7673% <ø> (ø)
parser	∅ <ø> (∅)
br	60.5247% <ø> (+15.4509%)	⬆️

[YangKeao]

/hold

I'm solving another issue #57312

[YangKeao]

As I've tested, the LOAD DATA in MySQL (both 5.6 and 8.0) also doesn't convert "false" to 0. I don't know why it's originally implemented (in #21310) as this.

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, wjhuang2016

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [D3Hunter,wjhuang2016]
• pkg/ddl/OWNERS [D3Hunter,wjhuang2016]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-11-12 03:09:38.388021211 +0000 UTC m=+325740.578890209: ☑️ agreed by D3Hunter.
• 2024-11-12 06:58:28.210823319 +0000 UTC m=+339470.401692315: ☑️ agreed by wjhuang2016.

[YangKeao]

/retest

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-6.5: #57354.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-7.1: #57355.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-7.5: #57356.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-6.1: #57357.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-8.5: #57358.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-8.1: #57359.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-5.4: #57360.