-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
table: fix the issue that the default value for BIT
column is wrong (#57303)
#57357
Open
ti-chi-bot
wants to merge
5
commits into
pingcap:release-6.1
Choose a base branch
from
ti-chi-bot:cherry-pick-57303-to-release-6.1
base: release-6.1
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
table: fix the issue that the default value for BIT
column is wrong (#57303)
#57357
ti-chi-bot
wants to merge
5
commits into
pingcap:release-6.1
from
ti-chi-bot:cherry-pick-57303-to-release-6.1
+70
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-chi-bot <[email protected]>
ti-chi-bot
added
release-note-none
Denotes a PR that doesn't merit a release note.
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
type/cherry-pick-for-release-6.1
This PR is cherry-picked to release-6.1 from a source PR.
labels
Nov 13, 2024
Merged
13 tasks
ti-chi-bot
bot
added
do-not-merge/cherry-pick-not-approved
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
cherry-pick-approved
Cherry pick PR approved by release team.
and removed
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
do-not-merge/cherry-pick-not-approved
labels
Nov 13, 2024
Signed-off-by: Yang Keao <[email protected]>
ti-chi-bot
bot
added
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
and removed
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
labels
Dec 5, 2024
YangKeao
changed the title
table: fix the issue that the default value for
table: fix the issue that the default value for Dec 5, 2024
BIT
column is wrong | tidb-test=pr/2424 (#57303)BIT
column is wrong (#57303)
/retest |
Signed-off-by: Yang Keao <[email protected]>
Signed-off-by: Yang Keao <[email protected]>
Signed-off-by: Yang Keao <[email protected]>
wjhuang2016
approved these changes
Dec 6, 2024
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wjhuang2016 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
ti-chi-bot
bot
added
needs-1-more-lgtm
Indicates a PR needs 1 more LGTM.
approved
labels
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
cherry-pick-approved
Cherry pick PR approved by release team.
needs-1-more-lgtm
Indicates a PR needs 1 more LGTM.
release-note-none
Denotes a PR that doesn't merit a release note.
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
type/cherry-pick-for-release-6.1
This PR is cherry-picked to release-6.1 from a source PR.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #57303
What problem does this PR solve?
Issue Number: close #57301, close #57312
Problem Summary:
CREATE TABLE
statement didn't assert whether the default value forBIT
is valid.BIT
column is casted multiple times and may cause unexpected behavior.What changed and how does it work?
BIT
default value.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.