Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

table: fix the issue that the default value for BIT column is wrong (#57303) #57356

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #57303

What problem does this PR solve?

Issue Number: close #57301, close #57312

Problem Summary:

  1. The CREATE TABLE statement didn't assert whether the default value for BIT is valid.
  2. The default value for BIT column is casted multiple times and may cause unexpected behavior.

What changed and how does it work?

  1. Revert part of types: convert string to MySQL BIT correctly #21310
  2. Validate the length of BIT default value.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Nov 13, 2024
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cherry-pick-approved Cherry pick PR approved by release team. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/cherry-pick-not-approved labels Nov 13, 2024
@ti-chi-bot ti-chi-bot closed this Dec 3, 2024
@YangKeao YangKeao reopened this Dec 5, 2024
Signed-off-by: Yang Keao <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 5, 2024
@YangKeao YangKeao requested a review from wjhuang2016 December 5, 2024 07:37
@YangKeao YangKeao changed the title table: fix the issue that the default value for BIT column is wrong | tidb-test=pr/2424 (#57303) table: fix the issue that the default value for BIT column is wrong | tidb-test=pr/2443 (#57303) Dec 5, 2024
Signed-off-by: Yang Keao <[email protected]>
@YangKeao YangKeao changed the title table: fix the issue that the default value for BIT column is wrong | tidb-test=pr/2443 (#57303) table: fix the issue that the default value for BIT column is wrong (#57303) Dec 5, 2024
@YangKeao
Copy link
Member

YangKeao commented Dec 5, 2024

/retest

1 similar comment
@YangKeao
Copy link
Member

YangKeao commented Dec 5, 2024

/retest

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 14 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-7.5@9d5e282). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.5     #57356   +/-   ##
================================================
  Coverage               ?   72.2784%           
================================================
  Files                  ?       1415           
  Lines                  ?     414378           
  Branches               ?          0           
================================================
  Hits                   ?     299506           
  Misses                 ?      94895           
  Partials               ?      19977           
Flag Coverage Δ
unit 72.2784% <33.3333%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9400% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 54.4983% <0.0000%> (?)

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 6, 2024
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 10, 2024
Copy link

ti-chi-bot bot commented Dec 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: windtalker, wjhuang2016

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Dec 10, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-06 07:42:44.184799577 +0000 UTC m=+1399951.804454093: ☑️ agreed by wjhuang2016.
  • 2024-12-10 01:55:51.184473945 +0000 UTC m=+317141.273276486: ☑️ agreed by windtalker.

@yibin87
Copy link
Contributor

yibin87 commented Dec 10, 2024

/test unit-test

Copy link

tiprow bot commented Dec 10, 2024

@yibin87: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@yibin87
Copy link
Contributor

yibin87 commented Dec 10, 2024

/test unit-test

Copy link

tiprow bot commented Dec 10, 2024

@yibin87: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot merged commit b298e21 into pingcap:release-7.5 Dec 10, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants