-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
table: fix the issue that the default value for BIT
column is wrong (#57303)
#57356
table: fix the issue that the default value for BIT
column is wrong (#57303)
#57356
Conversation
Signed-off-by: ti-chi-bot <[email protected]>
Signed-off-by: Yang Keao <[email protected]>
BIT
column is wrong | tidb-test=pr/2424 (#57303)BIT
column is wrong | tidb-test=pr/2443 (#57303)
Signed-off-by: Yang Keao <[email protected]>
BIT
column is wrong | tidb-test=pr/2443 (#57303)BIT
column is wrong (#57303)
/retest |
1 similar comment
/retest |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-7.5 #57356 +/- ##
================================================
Coverage ? 72.2784%
================================================
Files ? 1415
Lines ? 414378
Branches ? 0
================================================
Hits ? 299506
Misses ? 94895
Partials ? 19977
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: windtalker, wjhuang2016 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/test unit-test |
@yibin87: No presubmit jobs available for pingcap/[email protected] In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test unit-test |
@yibin87: No presubmit jobs available for pingcap/[email protected] In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This is an automated cherry-pick of #57303
What problem does this PR solve?
Issue Number: close #57301, close #57312
Problem Summary:
CREATE TABLE
statement didn't assert whether the default value forBIT
is valid.BIT
column is casted multiple times and may cause unexpected behavior.What changed and how does it work?
BIT
default value.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.