[Bugfix] Fix scratch dir value #71
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me but looking at our previous conversation, @pmb59 you might be the one to have more say on this one |
anilthanki
previously approved these changes
Oct 19, 2023
|
I just read the whole thread so please do not merge based on my approval.. I think this needs a discussion. |
|
Don't worry @anilthanki , I won't merge it now. |
|
I discussed this issue with @pmb59 and I refactored our own code that is using this repo's code to load data into our local environment. We don't need to apply this change request, so I am closing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change when
SCRATCH_DIRvariable was not defined as an environmental variable it got its value from theDIMRED_FILE_PATHthat also contained the filename.In the README the
DIMRED_FILE_PATHis defined: TSV file with the coordinates. We only need the path of the directory, so that is why I added this change.