Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to v2.0.0 #70

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Update to v2.0.0 #70

merged 1 commit into from
Oct 13, 2023

Conversation

alfonsomunozpomer
Copy link
Member

After merging the new experiment design loading script I think this deserves to receive a major version update. I added a section to README.md to load/delete experiment design in Postgres.

Remember to tag this with 2.0.0 if it’s merged to develop!

@alfonsomunozpomer alfonsomunozpomer marked this pull request as ready for review October 12, 2023 14:38
ke4
ke4 requested changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@ke4 ke4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small change request, otherwise fine by me. 👍

ke4
ke4 requested changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@ke4 ke4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I commented the wrong line in my previous comment. Sorry about that.

README.md Show resolved Hide resolved
@ke4 ke4 self-requested a review October 13, 2023 12:46
anilthanki
anilthanki approved these changes Oct 13, 2023
View reviewed changes
Copy link

@anilthanki anilthanki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alfonsomunozpomer alfonsomunozpomer merged commit 9901da5 into develop Oct 13, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ke4 ke4 ke4 approved these changes

@anilthanki anilthanki anilthanki approved these changes

@pmb59 pmb59 Awaiting requested review from pmb59

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alfonsomunozpomer @ke4 @anilthanki