Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update run_sccaf.xml #205

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Conversation

nomadscientist
Copy link
Collaborator

@nomadscientist nomadscientist commented Nov 9, 2020

Description

Added help text so people don't get stuffed by 'louvain_' being appended in the workflow to the anndata label for the clustering

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • I have made any required changes to upstream dependencies for a tool wrapper, and they are available in distribution channels (e.g. Pip, Conda).
  • If I have updated the underlying software for a tool wrapper (e.g. scanpy-scripts by changing the value of @TOOL_VERSION@), then I have reset all 'build' values to 0 (e.g. @TOOL_VERSION@+galaxy0)
  • If I have updated a tool wrapper without a software change, then I have bumped the associated 'build' values (e.g. @TOOL_VERSION@+galaxy0 @TOOL_VERSION@+galaxy1)

@nomadscientist
Copy link
Collaborator Author

How did this fail checks? All I did was add some text in the help text bit.

Added help text so people don't get stuffed by 'louvain_' being appended in the workflow to the anndata label for the clustering
@pcm32
Copy link
Member

pcm32 commented Dec 27, 2020

The test had been broken for some weeks. We recently finished moving to a new continuous integration provider, that is why we haven't been able to come back to your PRs, apologies @nomadscientist !

I have now rebased your PRs. In this one, could you please bump the number after the +galaxy in the version of the tool? Thanks!

@pcm32
Copy link
Member

pcm32 commented Dec 27, 2020

Ok, now tests are failing because test data is not available. I need to add the fetch from FTP part...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants