Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small refactoring to detector evaluation #240

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

sfmig
Copy link
Collaborator

@sfmig sfmig commented Nov 7, 2024

Description

What is this PR?

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?
Small edits to the evaluation code from reviewing #180

What does this PR do?

  • define frames_output_dir as an evaluation interface attribute
  • update readme to refer to other guides

References

Part of the work from #180

How has this PR been tested?

\

Does this PR require an update to the documentation?

\

Checklist:

  • The code has been tested locally
  • [ n\a ] Tests have been added to cover all new functionality
  • The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 47.97%. Comparing base (420e0f7) to head (849940f).

Files with missing lines Patch % Lines
crabs/detector/evaluate_model.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #240   +/-   ##
=======================================
  Coverage   47.97%   47.97%           
=======================================
  Files          24       24           
  Lines        1532     1534    +2     
=======================================
+ Hits          735      736    +1     
- Misses        797      798    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This was referenced Nov 7, 2024
@sfmig sfmig merged commit 9b4722e into main Nov 8, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants