Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored detection+tracking #241

Merged
merged 6 commits into from
Nov 8, 2024
Merged

Refactored detection+tracking #241

merged 6 commits into from
Nov 8, 2024

Conversation

sfmig
Copy link
Collaborator

@sfmig sfmig commented Nov 7, 2024

Description

What is this PR?

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?

What does this PR do?

  • Factors out and makes the steps in the detect+track pipeline more modular.

  • Removes some code duplications (e.g. when preparing data for sort, formating the detections dict...)

  • Reviews typing and docstrings

  • Adapts current tests to the changes

  • Same MOTA on GT clip as reference -- planned integration tests for next PR.

Work focuses mostly on the detect+track pipeline, as the tracker evaluation will be covered in a separate PR.

References

#180

How has this PR been tested?

Integration run manually on reference clip. Existing tests pass locally.

Does this PR require an update to the documentation?

No.

Checklist:

  • The code has been tested locally
  • Tests have been added to cover all new functionality
  • [ n/a ] The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

@sfmig sfmig mentioned this pull request Nov 7, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 36.41975% with 103 lines in your changes missing coverage. Please review.

Project coverage is 47.69%. Comparing base (9b4722e) to head (bef4974).

Files with missing lines Patch % Lines
crabs/tracker/utils/io.py 24.24% 50 Missing ⚠️
crabs/tracker/track_video.py 40.90% 39 Missing ⚠️
crabs/tracker/evaluate_tracker.py 47.61% 11 Missing ⚠️
crabs/tracker/utils/tracking.py 66.66% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #241      +/-   ##
==========================================
- Coverage   47.97%   47.69%   -0.29%     
==========================================
  Files          24       24              
  Lines        1534     1562      +28     
==========================================
+ Hits          736      745       +9     
- Misses        798      817      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfmig sfmig marked this pull request as ready for review November 8, 2024 12:07
@sfmig sfmig marked this pull request as draft November 8, 2024 12:08
@sfmig sfmig force-pushed the smg/detection-and-tracking-rev branch from 6349eb1 to 3c3a7df Compare November 8, 2024 14:44
@sfmig sfmig marked this pull request as ready for review November 8, 2024 17:57
@sfmig sfmig merged commit e371bf9 into main Nov 8, 2024
7 checks passed
@sfmig sfmig mentioned this pull request Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants