Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statistics: right deal with error for reading stats from storage #58048

Merged

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Dec 6, 2024

What problem does this PR solve?

Issue Number: ref #57901

Problem Summary:

What changed and how does it work?

if query meets the problem, it will return null error, then it lead to delete stats. it is a bug. so we can first fix this problem first.

Image
Image

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

right deal with error for reading stats from storage to avoid deleting stats

正确处理取统计信息的异常,来防止 stats 被误删除

Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. labels Dec 6, 2024
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Project coverage is 73.9509%. Comparing base (bb9096c) to head (2a0e744).
Report is 3 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #58048        +/-   ##
================================================
+ Coverage   73.1711%   73.9509%   +0.7798%     
================================================
  Files          1674       1704        +30     
  Lines        461507     470862      +9355     
================================================
+ Hits         337690     348207     +10517     
+ Misses       103079     101157      -1922     
- Partials      20738      21498       +760     
Flag Coverage Δ
integration 46.0530% <14.2857%> (?)
unit 72.3637% <57.1428%> (+0.0666%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 45.9983% <ø> (+0.0150%) ⬆️

@hawkingrei
Copy link
Member Author

/retest

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 6, 2024
Copy link

ti-chi-bot bot commented Dec 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, time-and-fate

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 6, 2024
Copy link

ti-chi-bot bot commented Dec 6, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-06 07:57:52.560148825 +0000 UTC m=+1400860.179803347: ☑️ agreed by time-and-fate.
  • 2024-12-06 08:41:10.435806077 +0000 UTC m=+1403458.055460578: ☑️ agreed by AilinKid.

@ti-chi-bot ti-chi-bot bot merged commit 1521bf7 into pingcap:master Dec 6, 2024
25 checks passed
@hawkingrei
Copy link
Member Author

/cherry-pick release-8.1-20241203-v8.1.1

@hawkingrei
Copy link
Member Author

/cherry-pick 8.5
/cherry-pick 8.1
/cherry-pick 7.5

@ti-chi-bot
Copy link
Member

@hawkingrei: cannot checkout 7.5: error checking out 7.5: exit status 1. output: error: pathspec '7.5' did not match any file(s) known to git

In response to this:

/cherry-pick 8.5
/cherry-pick 8.1
/cherry-pick 7.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

@hawkingrei: new pull request created to branch release-8.1-20241203-v8.1.1: #58057.

In response to this:

/cherry-pick release-8.1-20241203-v8.1.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

@hawkingrei: cannot checkout 8.1: error checking out 8.1: exit status 1. output: error: pathspec '8.1' did not match any file(s) known to git

In response to this:

/cherry-pick 8.5
/cherry-pick 8.1
/cherry-pick 7.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

@hawkingrei: cannot checkout 8.5: error checking out 8.5: exit status 1. output: error: pathspec '8.5' did not match any file(s) known to git

In response to this:

/cherry-pick 8.5
/cherry-pick 8.1
/cherry-pick 7.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@hawkingrei
Copy link
Member Author

/cherry-pick release-8.5
/cherry-pick release-8.1
/cherry-pick release-7.5

@ti-chi-bot
Copy link
Member

@hawkingrei: new pull request created to branch release-7.5: #58059.

In response to this:

/cherry-pick release-8.5
/cherry-pick release-8.1
/cherry-pick release-7.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Dec 6, 2024
@ti-chi-bot
Copy link
Member

@hawkingrei: new pull request created to branch release-8.1: #58060.

In response to this:

/cherry-pick release-8.5
/cherry-pick release-8.1
/cherry-pick release-7.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Dec 6, 2024
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Dec 6, 2024
@ti-chi-bot
Copy link
Member

@hawkingrei: new pull request created to branch release-8.5: #58061.

In response to this:

/cherry-pick release-8.5
/cherry-pick release-8.1
/cherry-pick release-7.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@hawkingrei
Copy link
Member Author

/cherrypick rlease-6.5
/cherrypick rlease-7.1

@ti-chi-bot
Copy link
Member

@hawkingrei: cannot checkout rlease-6.5: error checking out rlease-6.5: exit status 1. output: error: pathspec 'rlease-6.5' did not match any file(s) known to git

In response to this:

/cherrypick rlease-6.5
/cherrypick rlease-7.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

@hawkingrei: cannot checkout rlease-7.1: error checking out rlease-7.1: exit status 1. output: error: pathspec 'rlease-7.1' did not match any file(s) known to git

In response to this:

/cherrypick rlease-6.5
/cherrypick rlease-7.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@hawkingrei
Copy link
Member Author

/cherrypick release-6.5
/cherrypick release-7.1

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Dec 9, 2024
@ti-chi-bot
Copy link
Member

@hawkingrei: new pull request created to branch release-6.5: #58083.

In response to this:

/cherrypick release-6.5
/cherrypick release-7.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Dec 9, 2024
@ti-chi-bot
Copy link
Member

@hawkingrei: new pull request created to branch release-7.1: #58084.

In response to this:

/cherrypick release-6.5
/cherrypick release-7.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants