Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor and document testing #84

Merged
merged 3 commits into from
Sep 16, 2024
Merged

Conversation

cthoyt
Copy link
Contributor

@cthoyt cthoyt commented Sep 11, 2024

The /test directory is very hard to remember how it works. This PR does some minor refactoring and adds a README to make it more clear how testing works

  1. Puts all of the expected-paper.* into a new folder expected-draft/
  2. Updates the Makefile accordingly
  3. Adds a README

@cthoyt
Copy link
Contributor Author

cthoyt commented Sep 11, 2024

@xuanxu do you have any idea why these tests might be failing? I also experienced in a different branch that the make test command inside the image builder workflow fails. Is it possible there is some metadata injected by virtue of it being a PR that makes it fail?

@tarleb
Copy link
Collaborator

tarleb commented Sep 16, 2024

Thanks that's a significant improvement. The tests were just hacked together to catch the worst problems, a cleanup is most welcome.

I'm sorry for being so slow right now, there are too many things that I want to do simultaneously 🙈

Merging this despite the failing tests, as we're planning to remove the "golden pdf" tests anyway.

@tarleb tarleb marked this pull request as ready for review September 16, 2024 08:53
@tarleb tarleb merged commit f5f806b into openjournals:main Sep 16, 2024
1 of 2 checks passed
@cthoyt cthoyt deleted the document-testing branch September 16, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants