AcquirePipelineState null checks should check initialization state (ASV) #619
+50
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lled and the result was checked for nullptr. If the PipelineState fails to compile, it will still return a non-null result, so we need to check the initialized state if we want to handle a failure to compile. Signed-off-by: Tommy Walton <[email protected]>
rgba16f
approved these changes
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Calls to Shader::AcquirePipelineState should check if IsInitialized == true, not just check for null, because if the pipeline state fails to compile it will return a non-null value that is uninitialized.
How was this PR tested?
Ran ASV tests and the editor.