Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up imports, tidy up save / load preprocessing to be clearer. #73

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

JoeZiminski
Copy link
Member

@JoeZiminski JoeZiminski commented Aug 7, 2023

  1. Tidy up imports so that TYPE_CHECKING block is last, which makes more easier import sorting.
  2. Rework the save preprocessing function in run_full_pipeline to be clearer, and make a clear distinction between preprocessing and sorting by having the sorting function take the preprocessing path both the preprocess_data object.

@JoeZiminski JoeZiminski merged commit 90f1deb into dev Aug 7, 2023
1 check passed
@JoeZiminski JoeZiminski deleted the tidy_up_preprocess_logic_and_imports branch August 7, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant