Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error message when not running inside SLURM #11

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Conversation

adamltyson
Copy link
Member

Closes #8

Copy link

codecov bot commented Dec 8, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (95dd05f) 90.90% compared to head (3ccdec6) 92.00%.

Files Patch % Lines
slurmio/slurmio.py 72.72% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #11      +/-   ##
==========================================
+ Coverage   90.90%   92.00%   +1.09%     
==========================================
  Files           2        2              
  Lines          66       75       +9     
==========================================
+ Hits           60       69       +9     
  Misses          6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@JoeZiminski JoeZiminski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! but codecov is unhappy and I'm not certain what to do about it.

@adamltyson adamltyson merged commit 3cd1df7 into main Dec 8, 2023
20 of 21 checks passed
@adamltyson adamltyson deleted the error-message branch December 8, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a better error message when running not in a slurm job
2 participants