Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is this PR
Why is this PR needed?
mypy
was complaining on CI, see this failure.This started happening after neuroinformatics-unit/actions#71 was merged and a new NIU actions release was made. Basically,
mypy
now runs on Python 3.12 instead of 3.10, so it sees some additional errors (in our case, just 1 error). I was able to reproduce the error in a Python 3.12 environment locally.What does this PR do?
It fixed the issue
mypy
was complaining about, by ensuring thattime_coords
doesn't undergo a type change.References
neuroinformatics-unit/actions#71
How has this PR been tested?
Locally running
pre-commit
andpytest
.Is this a breaking change?
No.
Does this PR require an update to the documentation?
No.
Checklist: