Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exploring options for computing egocentric coordinate system #334

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sfmig
Copy link
Contributor

@sfmig sfmig commented Oct 24, 2024

Checking how to do this with scipy's spatial transformations module.

It has nice functionality also for interpolating rotations.


Before submitting a pull request (PR), please read the contributing guide.

Please fill out as much of this template as you can, but if you have any problems or questions, just leave a comment and we will help out :)

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?

What does this PR do?

References

Please reference any existing issues/PRs that relate to this PR.

How has this PR been tested?

Please explain how any new code has been tested, and how you have ensured that no existing functionality has changed.

Is this a breaking change?

If this PR breaks any existing functionality, please explain how and why.

Does this PR require an update to the documentation?

If any features have changed, or have been added. Please explain how the
documentation has been updated.

Checklist:

  • The code has been tested locally
  • Tests have been added to cover all new functionality
  • The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

Copy link

sonarcloud bot commented Oct 24, 2024

@niksirbi
Copy link
Member

niksirbi commented Oct 25, 2024

Well done @sfmig, I really like your approach using rotational alignment of two vectors. Perhaps it's time to have a go at a first implementation of egocentric transformation? Perhaps as from movement.transforms import to_egocentric?

I know this was not on you to-do list for this term, but you seem to have already done most of the conceptual work.

@sfmig
Copy link
Contributor Author

sfmig commented Oct 28, 2024

yeah I'd be happy to have a go!

I made a note for my next on-week for movement (it may be in a while, do let me know if this becomes priority tho)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants