Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix command for installation of docs dependencies in the guide. #323

Merged
merged 4 commits into from
Oct 17, 2024

Conversation

sfmig
Copy link
Contributor

@sfmig sfmig commented Oct 17, 2024

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?

  • It fixes the installation instructions for the docs dependencies
    • more details on the next section.
  • It combines all the dependencies installations into the same section.
    • Right now, the contributors first install movement in a development environment, and then install a few more additional dependencies to be able to build the docs locally in a later section. In this PR I put both steps in the same section.
  • Some small updates to the phrasing
    • e.g., make clean html cleans and re-builds the docs, so there is no need to run the build command again as the text suggests.

What does this PR do?
The docs requirements.txt file specifies the installation of the movement package on its first line, as -e .. The dot syntax refers to the current directory (the one executing the command), and it should match the location of the movement metadata file (pyproject.toml for us).

Since pyproject.toml is at the root of the directory, this means the command is expected to be run from the root of the directory too.

However, the documentation asks to run the pip install -r requirements.txt command from the docs directory. If this instructions are followed, we get an error because pip is unable to find the pyproject.toml file for the movement package.

Note that in CI we run the same command that this PR proposes (see here)

References

\

How has this PR been tested?

\

Is this a breaking change?

No.

Does this PR require an update to the documentation?

\

Checklist:

  • The code has been tested locally
  • [ n/a ] Tests have been added to cover all new functionality
  • The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.77%. Comparing base (a42838d) to head (158f52f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #323   +/-   ##
=======================================
  Coverage   99.77%   99.77%           
=======================================
  Files          15       15           
  Lines         909      909           
=======================================
  Hits          907      907           
  Misses          2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfmig sfmig marked this pull request as ready for review October 17, 2024 12:15
@sfmig sfmig force-pushed the smg/fix-building-docs-instructions branch from c942e4a to 158f52f Compare October 17, 2024 12:15
Copy link

sonarcloud bot commented Oct 17, 2024

@sfmig sfmig requested a review from a team October 17, 2024 12:21
Copy link
Member

@niksirbi niksirbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this @sfmig, LGTM.

Perhaps the more permanent solution here is to have movement[docs] extras, but that would necessitate a change in our docs building/publishing actions, which I want to avoid for now.

@niksirbi niksirbi added this pull request to the merge queue Oct 17, 2024
Merged via the queue into main with commit b399ce0 Oct 17, 2024
17 checks passed
@lochhh lochhh deleted the smg/fix-building-docs-instructions branch October 25, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants