Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated EPM analysis notebook and solutions #16

Merged
merged 9 commits into from
Oct 1, 2024

Conversation

niksirbi
Copy link
Member

@niksirbi niksirbi commented Sep 30, 2024

The notebook has been updated according to movement v0.0.20.

I opted for teaching the functional syntax for filtering and kinematics (as opposed to using the accessor), because it requires less explanation.

@lochhh I'd be grateful if you could go over it once to check for bugs and types.

@niksirbi niksirbi marked this pull request as ready for review September 30, 2024 14:51
@niksirbi niksirbi requested a review from lochhh September 30, 2024 14:52
@sfmig sfmig mentioned this pull request Oct 1, 2024
Copy link
Contributor

@lochhh lochhh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go 🚀

  • Removed extra ; from plt.imshow(frame_img); in both notebooks
  • Added missing solution for visualising the DLC data at each processing step
  • Removed tail_base from needed_keypoints in computing result_sleap_video2, in case people copy and paste this for the DLC exercise (this will throw an error as it is tailbase in the DLC data)

@niksirbi
Copy link
Member Author

niksirbi commented Oct 1, 2024

Thanks @lochhh, all good calls!

@niksirbi niksirbi merged commit 1d93c65 into main Oct 1, 2024
1 check passed
@niksirbi niksirbi deleted the updated-epm-anysis-notebook branch October 1, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants