fix(images): images suited for black background #146
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wrussell1999
approved these changes
May 16, 2024
wrussell1999
requested changes
May 16, 2024
There was a problem hiding this comment.
You need to update the icon to handle black / white theme, example of wrong [one](https://raw.githubusercontent.com/kestra-io/kestra/6de50afeca9600dbf1c528f7daa5a3bf9a664e82/core/src/main/resources/icons/io.kestra.core.tasks.flows.WaitFor.svg), good [one](https://raw.githubusercontent.com/kestra-io/kestra/d28b63de0feef1ea629ce04e76987af4f6076c1d/core/src/main/resources/icons/io.kestra.core.tasks.flows.Pause.svg). The main difference is :
fill="currentColor"
that allow to change the color of the svg.
Please take care of this?
|
There looks to be a bug in passing currentColor to these pages. I have created the issue: kestra-io/plugin-fs#127 for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.