-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some plugin icons are black on dark website — find icons that work on both light and dark mode #1294
Comments
@shrutimantri has made a number of PRs to convert these. However, I've realised that we need these icons to work in dark and light mode as they are also used in the Kestra UI (which can be either). Shruti's tweaks make it so they do work on a light background but not as well as a dark icon would. I've merged one but holding off with the realisation of working on both. kestra-io/plugin-jdbc#306 |
@shrutimantri please instead do this You need to update the icon to handle black / white theme, example of wrong one, good one. The main difference is : |
Can we revert the one you merged @wrussell1999 |
Reverted kestra-io/plugin-serdes#114 |
will be done as part of kestra-io/kestra#4154 because we will be able to change SVG icon colors via code (e.g. revert colors) |
Describe the issue
https://kestra.io/plugins/plugin-script-shell/tasks/scripts/io.kestra.core.tasks.scripts.bash
Icons should be in light version so they are properly visible
Environment
The text was updated successfully, but these errors were encountered: