-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update how to define a sequencing experiment in validator #19
base: develop
Are you sure you want to change the base?
update how to define a sequencing experiment in validator #19
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the regular expression isn't properly formatted. It can only have /
at the start and end, or?
Should be /seq|-C$|CUT&RUN/i
this?
Thank you Anja for checking! I couldn't test the changes by running the whole script, so I made an array object and for each item tested with regular expression in that way. It was working well. |
Hi @YalanBi, I found one more experiment type we should cover: "spatial transcriptomics by high-throughput sequencing". So anything ending in |
Good morning @anjaf! If we want to include "spatial transcriptomics by high-throughput sequencing” only (“spatial transcriptomics” not included), it will be spotted by searching “having seq” - no more changes needed. |
Should I change to this way as you suggested? |
Hi @YalanBi , you're right, I realised later that anything "sequencing" is already covered. |
Alright, @anjaf! It's done! |
add two new rules: