Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update how to define a sequencing experiment in validator #19

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

YalanBi
Copy link

@YalanBi YalanBi commented Sep 16, 2021

add two new rules:

  • ending with "-C" to include “Capture-C” and “Hi-C”
  • an exception for “CUT&RUN”, which we would like to add to AE experiment types in the future

Copy link
Member

@anjaf anjaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the regular expression isn't properly formatted. It can only have / at the start and end, or?
Should be /seq|-C$|CUT&RUN/i this?

@YalanBi
Copy link
Author

YalanBi commented Sep 16, 2021

Thank you Anja for checking! I couldn't test the changes by running the whole script, so I made an array object and for each item tested with regular expression in that way. It was working well.
But if we don't require "ending with '-C' (capital letter) and 'CUT&RUN' (all capital letters), I can definitely change to how you suggest. I also tested in your way, and it was working as well.

@anjaf
Copy link
Member

anjaf commented Sep 24, 2021

Hi @YalanBi, I found one more experiment type we should cover: "spatial transcriptomics by high-throughput sequencing". So anything ending in seq or sequencing makes sense.

@YalanBi
Copy link
Author

YalanBi commented Sep 27, 2021

Good morning @anjaf! If we want to include "spatial transcriptomics by high-throughput sequencing” only (“spatial transcriptomics” not included), it will be spotted by searching “having seq” - no more changes needed.

@YalanBi
Copy link
Author

YalanBi commented Sep 27, 2021

I think the regular expression isn't properly formatted. It can only have / at the start and end, or?
Should be /seq|-C$|CUT&RUN/i this?

Should I change to this way as you suggested?

@anjaf
Copy link
Member

anjaf commented Sep 27, 2021

Hi @YalanBi , you're right, I realised later that anything "sequencing" is already covered.
Yes, please update the regex as suggested.

@YalanBi
Copy link
Author

YalanBi commented Sep 28, 2021

Alright, @anjaf! It's done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants