Feature/check md5 changes #30
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added saving md5 of workflow and parameters files inside of ExecutionState class * Added comparison of new and previous md5's
|
Hi @Claptar, apologies for missing this, a great a addition! This looks good to me in general, and the test is passing. I'll give it a closer look and merge soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#28 Added saving and checking file's md5 functionality to ExecutionState class. I decided to go with #28 (comment) option.
I am not very sure if
check_md5function (line 460 init.py) could have been written in a more readable way.Also, wonder if I should have added "Yes/No" question after #28 (comment).