Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ScPred - version inconsistency for feature selection #302

Open
hexhowells opened this issue Aug 23, 2023 · 1 comment
Open

ScPred - version inconsistency for feature selection #302

hexhowells opened this issue Aug 23, 2023 · 1 comment

Comments

@hexhowells
Copy link
Contributor

I am building a workflow in Galaxy using scPred and have encountered an issue with the latest version (1.0.2+galaxy0) of the tool ScPred feature space, when running the tool i get the following error:

Error in getFeatureSpace(data_seurat, pvar = opt$prediction_column, correction = opt$correction_method,  : 
  Invalid class for object: must be 'Seurat'
Execution halted

It seems the tool only accepts Seurat objects, however all prior tools that should be run output a SingleCellExperiment or ScPred object.

When using a previous version of the tool (1.0.1+galaxy0) it runs fine with no errors, as I believe prior versions accept Seurat and ScPred objects.


Also to note the prior tools that get run (Scpred pre-process/Scpred train-test split and Scpred eigen-decompose) all have the latest version as 1.0.1+galaxy0. So i'm guessing either the updated version has broken something or only some of the tools have been updated?

A Galaxy workflow reproducing the error can be found here. Step 13 uses the latest version of the ScPred feature space tool whereas 29 uses the latest version.

@pcm32
Copy link
Member

pcm32 commented Sep 22, 2023

@hexhowells I have managed to merge changes on scPred-cli to make the continous integration test work. I have added Seurat and loomexperiment as depenedncies for the testing process, so the SingleCellExperiment objects with Seurat or loom flavour should work once we make a new release of scpred-cli. Towards this end, do you have any other needs that we need to incorporate on scPred-cli before releasing it? If that is so, could you PR here please? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants