bugfix/update-cell-type-marker-genes-endpoint-to-accept-slash-in-the-celltype #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the frondend celltypewheel when we clicked on celltype with / value, backend not accepting that URI, so we were added encodeURIComponent(btoa) functions at frontend to do Base64 encode of celltype
as part of URI to accept '/' by the tomcat and API endpoint(/json/cell-type-marker-genes/{cellType})
Signed-off-by: upendrakumbham <[email protected]>
Signed-off-by: upendrakumbham <[email protected]>
Signed-off-by: upendrakumbham <[email protected]>
Signed-off-by: upendrakumbham <[email protected]>
ke4
requested changes
Sep 26, 2024
...n/java/uk/ac/ebi/atlas/search/metadata/JsonMultiexperimentCellTypeMarkerGenesController.java
Outdated
Show resolved
Hide resolved
...n/java/uk/ac/ebi/atlas/search/metadata/JsonMultiexperimentCellTypeMarkerGenesController.java
Outdated
Show resolved
Hide resolved
...ava/uk/ac/ebi/atlas/search/metadata/JsonMultiexperimentCellTypeMarkerGenesControllerWIT.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Károly Erdős <[email protected]>
Co-authored-by: Károly Erdős <[email protected]>
Signed-off-by: upendrakumbham <[email protected]>
Signed-off-by: upendrakumbham <[email protected]>
ke4
previously approved these changes
Oct 2, 2024
Signed-off-by: upendrakumbham <[email protected]>
Signed-off-by: upendrakumbham <[email protected]>
ke4
approved these changes
Oct 4, 2024
upendrakumbham
deleted the
bugfix/update-cell-type-marker-genes-endpoint-to-accept-slash-in-the-celltype
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Base64 decoder to decode cell type which is received by the frontend
In the frontend celltypewheel when we clicked on cell type with / value, the backend did not accept that URI, so we added encodeURIComponent(btoa) functions at the frontend to do Base64 encode of cell type as part of URI to accept '/' by the tomcat and API endpoint(/json/cell-type-marker-genes/{cellType})