-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decoupling tabs in the experiment page and display them after validating #375
Open
upendrakumbham
wants to merge
40
commits into
develop
Choose a base branch
from
bugfix/decouple-experiment-page-tabs-and-validate-before-displaying
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 5 commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
f0677d3
Initial commit on decoupling tabs in the experiment page
upendrakumbham a21e6ee
Merge branch 'develop' into bugfix/decouple-experiment-page-tabs-and-…
upendrakumbham 7a48932
Add multiple ternary conditional operator
upendrakumbham a071970
Merge branch 'develop' into bugfix/decouple-experiment-page-tabs-and-…
upendrakumbham aa55ced
Improved version of code after a tweak of tab conditions
upendrakumbham 585972d
Add fubctions to validate tabs and it's props
upendrakumbham 25ef163
Remove compilation errors and improve functions
upendrakumbham 13e7ee2
Remove unused code and improve function
upendrakumbham 532389c
remove hardcode strings and reuse code
upendrakumbham 1f9aa46
Add tabtype 'resources' conditional check
upendrakumbham 2c05e1a
Add empty object check and null, undefined function and update tab va…
upendrakumbham ca946ac
Fix camel casing in the function
upendrakumbham ea37496
Initiate tabTypeComponent = []; before return statement to clear data
upendrakumbham fcaab7c
Remove log messages
upendrakumbham 05d2fb2
Improved code by removing if, else conditions & removed redundant code
upendrakumbham 35bceb9
Merge branch 'develop' into bugfix/decouple-experiment-page-tabs-and-…
upendrakumbham 99088cf
Move all helper functions to tabConfig.js file as part of ExperiemntP…
upendrakumbham b1cf7e5
Move PropTypes to propTypes.js file as part of ExperiemntPageRouter.j…
upendrakumbham 5eaf719
Improved file
upendrakumbham dcf06f8
Add validation fields (common & specific)for the tabs
upendrakumbham e84663d
Add validations for tabs and common props
upendrakumbham 08588ac
Remove renamed file
upendrakumbham bef7792
Merge branch 'develop' into bugfix/decouple-experiment-page-tabs-and-…
upendrakumbham a60205f
result tab validations
upendrakumbham 53c0ce8
conflict resolved html demo page update
upendrakumbham 7189295
add a suggesterEndpoint validation to the result tab
upendrakumbham d4179e1
add experiment-design tab validations
upendrakumbham 4d3abc1
Add validation attributes to the 'Supplementary-information' and 'Dow…
upendrakumbham bf01724
Common validations code improvements
upendrakumbham 21731ac
Add inner tab validations and make it result tab enablement depends o…
upendrakumbham 865c176
Update TabConfig
upendrakumbham fea148e
Refactor a function name
upendrakumbham 707dd79
Improve cell plots tab validations function
upendrakumbham 0473eeb
Improve cell plots tab and marker genes tab validations
upendrakumbham a690dfc
Add backend ksWithMarkerGenes attribute payload for the marker genes …
upendrakumbham 4ef6772
Remove console.log messages and ; to make code consistent
upendrakumbham 10a0f14
Made code format changes to make code consitent
upendrakumbham 76ed29e
Delete propTypes.js file
upendrakumbham f9a1240
Refactor variable name
upendrakumbham 2887bfb
Merge branch 'develop' into bugfix/decouple-experiment-page-tabs-and-…
upendrakumbham File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@upendrakumbham Could you clean this code please? We are watching Uncle Bob's Clean Code videos to apply his teaching in our every day coding.
I would like you to find yourself why this code is not clean and I would like you to change it. It is not that hard.
If you struggle with it, then please ping me and I can help, but I would really like to see that you can do it yourself.
Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as per @lingyun1010 review comment, I have created JS functions to validate tabs and it's props.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please review and provide comments