Fix the props and func for marker gene heatmap tab #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alfonsomunozpomer
requested changes
Aug 8, 2023
| selectedClusterId={this.state.selectedClusterId} | ||
| onChangeClusterId={(colourByCategory, colourByValue) => { | ||
| selectedK={this.state.selectedClusterId} | ||
| onSelectK={(colourByValue,colourByCategory) => { |
There was a problem hiding this comment.
The parameter colourByCategory isn’t passed and it’s also not in the function signature. Let’s remove it. I guess it’s a leftover from the previous onChangeClusterId.
lingyun1010
deleted the
bugfix/marker-gene-heatmap-ks-dropdown-not-loading
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marker gene heatmap page has a bug on the clusters dropdown menu, the selected value is not showing properly like in the screenshot below. I fixed the bug by testing the in the JS bundle with webpack server, i.e. without in the scxa server. The reviewer can also review it in the same way.