Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor experiment's external resource handling #148

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from
Open

Refactor experiment's external resource handling #148

wants to merge 11 commits into from

Conversation

ke4
Copy link
Contributor

@ke4 ke4 commented Oct 24, 2024 •
edited
Loading

This is a complete refactor of experiment's external resource handling.

  • There was an error regarding to EGA resource links. Every link's URI contained /studies even if that resource was a dataset.
  • Also some archive's base resource link has been updated.

Accompanying PR in atlas-web-bulk: Refactor experiment's external resource handling #214

Manual checks

  • This branch is passing the CI tests as part of a pull request in the atlas-web-bulk or atlas-web-scxa repos and I have indicated that PR here.

@ke4 ke4 added the bug Something isn't working label Oct 24, 2024
@ke4 ke4 self-assigned this Oct 24, 2024
@ke4 ke4 changed the title [bugfix] Add options to generate EGA links to multiple resource types Add options to generate EGA links to multiple resource types Oct 24, 2024
@ke4 ke4 changed the title Add options to generate EGA links to multiple resource types Refactor experiment's external resource handling Oct 29, 2024
@ke4 ke4 marked this pull request as ready for review October 29, 2024 15:17
@ke4 ke4 mentioned this pull request Oct 29, 2024
Open
upendrakumbham
upendrakumbham approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@upendrakumbham upendrakumbham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of refactoring :). All Looks good to me!

lingyun1010
lingyun1010 approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@lingyun1010 lingyun1010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good to me. Tested locally and all external resources links seem working well in my local environment. Do we need another PR for the updated core submodule if they are sharing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@upendrakumbham upendrakumbham upendrakumbham approved these changes

@lingyun1010 lingyun1010 lingyun1010 approved these changes

Assignees

@ke4 ke4

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ke4 @upendrakumbham @lingyun1010