Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore] Bulk - Fix experiment design's memory issue #203

Merged
merged 14 commits into from
Jun 26, 2024

Conversation

ke4
Copy link
Contributor

@ke4 ke4 commented Jun 12, 2024

Changes:

  • Remove experiment design field from Experiment. (Temporary leave experimentDesign field on Experiment entity to pass the test. I am going to remove it in the last commit.)

Temporary leave experimentDesign field on Experiment entity to pass the test. I am going to remove it in the last commit
@ke4 ke4 added bug Something isn't working high priority Improvement Improve/refactor existing code labels Jun 12, 2024
@ke4 ke4 self-assigned this Jun 12, 2024
@ke4 ke4 marked this pull request as ready for review June 18, 2024 14:37
@ke4 ke4 requested a review from upendrakumbham June 20, 2024 15:33
Copy link
Contributor

@upendrakumbham upendrakumbham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me!

@ke4 ke4 merged commit c21eeba into develop Jun 26, 2024
2 checks passed
lingyun1010 added a commit that referenced this pull request Jul 23, 2024
…rmation page (#204)

* Decoupling external link resources from experiment

type

* Bump atlas-web-core

* Add autowired for link beans

* Refactor codes for arrayexpress

* Bump atlas-web-core

* [Chore] Bulk - Fix experiment design's memory issue  (#203)

* Remove experiment design field from Experiment

Temporary leave experimentDesign field on Experiment entity to pass the test. I am going to remove it in the last commit

* Refactor ExperimentsConditionsDetailsController

* Refactor BaselineExperimentAssayGroupsLines

* Refactor BaselineExperimentPageService

* Refactor HeatmapGroupingsService

* Refactor DifferentialExperimentPageService

* Refactor EvidenceService

* Refactor EvidenceService - left over

* Refactor ContrastSummaryController

* Refactor ExperimentPageContentService

* update with the latest atlas-web-core module changes

* Remove experimentDesign field from Experiment entity (latest core changes)

* Update to the latest atlas-web-core module changes

* Refactor getExperimentDesign method usage

* Refactor externalResourcesLinks

Co-authored-by: Károly Erdős <[email protected]>

* Bump atlas-web-core

* Refactor the external resources links

* Bump altas-web-core

* Decoupling external link resources from experiment

type

* Bump atlas-web-core

* Add autowired for link beans

* Refactor codes for arrayexpress

* Refactor externalResourcesLinks

Co-authored-by: Károly Erdős <[email protected]>

* Refactor the external resources links

---------

Co-authored-by: Károly Erdős <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working high priority Improvement Improve/refactor existing code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants