-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Chore] Bulk - Fix experiment design's memory issue #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Temporary leave experimentDesign field on Experiment entity to pass the test. I am going to remove it in the last commit
ke4
added
bug
Something isn't working
high priority
Improvement
Improve/refactor existing code
labels
Jun 12, 2024
app/src/main/java/uk/ac/ebi/atlas/experimentpage/json/opentargets/EvidenceService.java
Outdated
Show resolved
Hide resolved
upendrakumbham
approved these changes
Jun 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good to me!
lingyun1010
added a commit
that referenced
this pull request
Jul 23, 2024
…rmation page (#204) * Decoupling external link resources from experiment type * Bump atlas-web-core * Add autowired for link beans * Refactor codes for arrayexpress * Bump atlas-web-core * [Chore] Bulk - Fix experiment design's memory issue (#203) * Remove experiment design field from Experiment Temporary leave experimentDesign field on Experiment entity to pass the test. I am going to remove it in the last commit * Refactor ExperimentsConditionsDetailsController * Refactor BaselineExperimentAssayGroupsLines * Refactor BaselineExperimentPageService * Refactor HeatmapGroupingsService * Refactor DifferentialExperimentPageService * Refactor EvidenceService * Refactor EvidenceService - left over * Refactor ContrastSummaryController * Refactor ExperimentPageContentService * update with the latest atlas-web-core module changes * Remove experimentDesign field from Experiment entity (latest core changes) * Update to the latest atlas-web-core module changes * Refactor getExperimentDesign method usage * Refactor externalResourcesLinks Co-authored-by: Károly Erdős <[email protected]> * Bump atlas-web-core * Refactor the external resources links * Bump altas-web-core * Decoupling external link resources from experiment type * Bump atlas-web-core * Add autowired for link beans * Refactor codes for arrayexpress * Refactor externalResourcesLinks Co-authored-by: Károly Erdős <[email protected]> * Refactor the external resources links --------- Co-authored-by: Károly Erdős <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes: