[Bugfix] Alternative view refactoring #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately test code was not adjusted when the `download` endpoint has been changed in February 2022 and probably the tests were not executed before the PR as merged. :-(
git.properties is being generated by the plugin
…p/atlas-web-bulk into bugfix/alternative_view_refactoring
ke4
added
bug
lingyun1010
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactor fix the previous implementation of the alternate view feature.
The previous implementation was creating an infinite loop when starting up the web app and loading the experiments.
This implementation changed the way how we check the type of the alternative experiment.
It's companion PR in atlas-web-core: ebi-gene-expression-group/atlas-web-core#136