Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCXA SolrCloud image #5

Merged
merged 3 commits into from
May 21, 2021
Merged

Conversation

alfonsomunozpomer
Copy link
Member

An image that contains an empty SolrCloud instance ready to use in testing and CI workflows. It’s just one SolrCloud node running with an embedded ZooKeeper.

I’ve added an action to publish to Quay but until it runs I won’t know for sure it works.

.github/workflows/scxa-solrcloud.yaml Outdated Show resolved Hide resolved
.github/workflows/scxa-solrcloud.yaml Outdated Show resolved Hide resolved
@alfonsomunozpomer
Copy link
Member Author

Thanks @pinin4fjords for the suggestions. I just copied the GH Actions Runner YAML just in case there were some particularities of GH actions I wasn’t aware of. I modified the action as per your suggestions. Let me know how that looks now.

@pinin4fjords
Copy link
Member

Looks good!

@pinin4fjords
Copy link
Member

pinin4fjords commented May 19, 2021

Apologies, thinking a bit I actually think you're going to need to reinstate something analagous to the ACTIONS_RUNNER bit, changed to point at a VERSION string or something in your Dockerfile, otherwise we'll have nothing to differentiate future iterations of the image (the SOLR version alone isn't all that useful). As things are that will also be needed to trigger the action, since changes to your submodules won't do it.

I wonder if your submodules are the way to go actually. Maybe we should have INDEX-BIOENTITIES_VERSION and INDEX-SCXA_VERSION in the Dockerfile, and CURL released versions of those (similar to https://github.com/ebi-gene-expression-group/atlas-containers/blob/master/github-actions-runner/Dockerfile). Though ultimately both of your submodules here should probably be independent versioned containers, and we can combine those versions to append to the solr version here, so maybe we just wait until we get round to that. The simple VERSION above will be a good idea though.

@alfonsomunozpomer alfonsomunozpomer merged commit 16c7136 into master May 21, 2021
@alfonsomunozpomer alfonsomunozpomer deleted the feature/scxa-solrcloud-image branch May 21, 2021 10:26
@alfonsomunozpomer
Copy link
Member Author

Ah, the image build failed because of submodules not being in the expected path. I’ve created and assigned #6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants