Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve lint workflow #2839

Merged
merged 2 commits into from
Dec 9, 2024
Merged

Improve lint workflow #2839

merged 2 commits into from
Dec 9, 2024

Conversation

muodov
Copy link
Member

@muodov muodov commented Dec 6, 2024

Reviewer:

Description:

https://app.asana.com/0/892838074342800/1208921863159441/f

Steps to test this PR:

Automated tests:

  • Unit tests
  • Integration tests
Reviewer Checklist:
  • Ensure the PR solves the problem
  • Review every line of code
  • Ensure the PR does no harm by testing the changes thoroughly
  • Get help if you're uncomfortable with any of the above!
  • Determine if there are any quick wins that improve the implementation
PR Author Checklist:
  • Get advice or leverage existing code
  • Agree on technical approach with reviewer (if the changes are nuanced)
  • Ensure that there is a testing strategy (and documented non-automated tests)
  • Ensure there is a documented monitoring strategy (if necessary)
  • Consider systems implications

@muodov muodov requested a review from kzar December 6, 2024 13:09
@muodov muodov requested a review from kzar December 6, 2024 13:57
@muodov
Copy link
Member Author

muodov commented Dec 9, 2024

@sammacbeth fyi the test failures seem unrelated, but they block merging

@kzar kzar merged commit 676e14d into main Dec 9, 2024
22 of 24 checks passed
@kzar
Copy link
Collaborator

kzar commented Dec 9, 2024

@sammacbeth fyi the test failures seem unrelated, but they block merging

I think it was the unresolved conversations that blocked merging, but no matter it's merged now. Thanks again!

@muodov muodov deleted the lint-diff branch December 9, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants