Improve lint workflow (#2839)

* Improve lint workflow

* Fix typo

.github/workflows/checks.yml

@@ -15,7 +15,7 @@ jobs:
                   node-version: 20
                   cache: 'npm'
             - run: npm run install-ci
-            - run: npm run lint
+            - run: npm run lint && echo 'No lint issues!' || (npm run lint-fix; git diff; echo 'Lint check failed, review diff above or run "npm run lint-fix"'; return 1)
 
     build:
         strategy:

CONTRIBUTING.md

@@ -107,10 +107,14 @@ The extension imports several DDG-owned modules (see [package.json](https://gith
 
 ### Linting
 - All linting: `npm run lint`
-    - This includes both the ESLint and TypeScript checks.
+    - This includes the ESLint and TypeScript checks as well as Prettier style checks.
+    - To automatically fix all lint issues: `npm run lint-fix`
 - ESLint linting: `npm run eslint`
     - To automatically fix mistakes found (where possible) use: `npm run eslint-fix`
 - TypeScript Linting: `npm run tsc`
+- Prettier linting: `npm run prettier`
+    - To automatically fix style issues use: `npm run prettier-fix`
+    - Since Prettier rules are stylistic-only, it is okay to add `// prettier-ignore` comments to ignore specific lines or blocks of code.
 
 ### Testing
 - Unit tests: `npm test` (full docs [here](./unit-test/README.md))

package.json

@@ -13,7 +13,10 @@
         "dev": "echo 'Try npm run dev-firefox or npm run dev-chrome instead' && exit 0",
         "eslint": "eslint '*.js' shared/js shared/data unit-test integration-test scripts",
         "eslint-fix": "npm run eslint -- --fix",
-        "lint": "npm run eslint && prettier . --check && npm run tsc",
+        "prettier": "prettier . --check",
+        "prettier-fix": "prettier . --write",
+        "lint": "npm run eslint && npm run prettier && npm run tsc",
+        "lint-fix": "npm run eslint-fix && npm run prettier-fix",
         "test": "npm run test.unit && npm run test.node",
         "test.unit": "make unit-test",
         "test.node": "make node-test",