Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update privacy-dashboard dependency to 7.4.0 #2838

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

kzar
Copy link
Collaborator

@kzar kzar commented Dec 6, 2024

With this dependency update, the "GetToggleReportOptions" privacy-dashboard
message now also handles the "locale" param ID, so let's start passing that too.

Also, it seems that the auto-generated shared/js/ui/base/locale-resources.js
file fails the new Prettier linting checks. This file should probably live in
the build/ directory instead of the source tree, but for now let's at least
tweak the script that creates it to follow Prettier's rules.

Reviewer: @sammacbeth

Description:

Steps to test this PR:

Automated tests:

  • Unit tests
  • Integration tests
Reviewer Checklist:
  • Ensure the PR solves the problem
  • Review every line of code
  • Ensure the PR does no harm by testing the changes thoroughly
  • Get help if you're uncomfortable with any of the above!
  • Determine if there are any quick wins that improve the implementation
PR Author Checklist:
  • Get advice or leverage existing code
  • Agree on technical approach with reviewer (if the changes are nuanced)
  • Ensure that there is a testing strategy (and documented non-automated tests)
  • Ensure there is a documented monitoring strategy (if necessary)
  • Consider systems implications

@kzar kzar force-pushed the update-dashboard-locale branch 2 times, most recently from 3a7604b to 2059743 Compare December 6, 2024 12:15
@kzar kzar marked this pull request as draft December 6, 2024 12:20
@kzar kzar force-pushed the update-dashboard-locale branch from 2059743 to 4f041a0 Compare December 6, 2024 14:16
@kzar kzar changed the title Update privacy-dashboard dependency to 7.3.2 Update privacy-dashboard dependency to 7.4.0 Dec 6, 2024
@kzar kzar marked this pull request as ready for review December 6, 2024 14:18
@kzar kzar force-pushed the update-dashboard-locale branch 2 times, most recently from 86fc3db to 7908e3b Compare December 7, 2024 13:50
With this dependency update, the "GetToggleReportOptions" privacy-dashboard
message now also handles the "locale" param ID, so let's start passing that too.

Also, it seems that the auto-generated shared/js/ui/base/locale-resources.js
file fails the new Prettier linting checks. This file should probably live in
the build/ directory instead of the source tree, but for now let's at least
tweak the script that creates it to follow Prettier's rules.
@kzar kzar force-pushed the update-dashboard-locale branch from 7908e3b to 3874f3b Compare December 7, 2024 13:52
@kzar kzar requested a review from sammacbeth December 7, 2024 13:53
@kzar kzar merged commit c8ec311 into duckduckgo:main Dec 9, 2024
21 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants