Skip to content

Commit

Permalink
Update privacy-dashboard dependency to 7.4.0
Browse files Browse the repository at this point in the history
The GetToggleReportOptions privacy-dashboard message now also handles the
"locale" param ID, so let's start passing that too.

Also, it seems that the auto-generated shared/js/ui/base/locale-resources.js
file fails the new Prettier linting checks. This file should probably live in
the build/ directory instead of the source tree, but for now let's at least
tweak the script that creates it to follow Prettier's rules.
  • Loading branch information
kzar committed Dec 7, 2024
1 parent 0a03026 commit 86fc3db
Show file tree
Hide file tree
Showing 5 changed files with 13 additions and 11 deletions.
13 changes: 6 additions & 7 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@
"@duckduckgo/content-scope-scripts": "github:duckduckgo/content-scope-scripts#6.34.0",
"@duckduckgo/ddg2dnr": "file:packages/ddg2dnr",
"@duckduckgo/jsbloom": "^1.0.2",
"@duckduckgo/privacy-dashboard": "github:duckduckgo/privacy-dashboard#7.1.1",
"@duckduckgo/privacy-dashboard": "github:duckduckgo/privacy-dashboard#7.4.0",
"@duckduckgo/privacy-grade": "file:packages/privacy-grade",
"@duckduckgo/privacy-reference-tests": "github:duckduckgo/privacy-reference-tests#main",
"@duckduckgo/tracker-surrogates": "github:duckduckgo/tracker-surrogates#1.3.2",
Expand Down
6 changes: 3 additions & 3 deletions scripts/bundleLocales.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ locales.forEach((lang) => {
const resources = namespaces
.map((ns) => {
const importName = `${lang}${ns[0].toUpperCase()}${ns.slice(1)}`;
imports.push(`import ${importName} from '../../../locales/${lang}/${ns}.json'`);
imports.push(`import ${importName} from '../../../locales/${lang}/${ns}.json';`);
return `${ns}: ${importName}`;
})
.join(', ');
Expand All @@ -29,5 +29,5 @@ ${imports.join('\n')}
export default {
${Object.keys(localeObjects)
.map((lang) => `${lang}: ${localeObjects[lang]}`)
.join(',\n ')}
}`);
.join(',\n ')},
};`);
1 change: 1 addition & 0 deletions shared/js/background/components/toggle-reports.js
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ export default class ToggleReports {
'features',
'httpErrorCodes',
'jsPerformance',
'locale',
'openerContext',
'requests',
'userRefreshCount',
Expand Down
2 changes: 2 additions & 0 deletions unit-test/background/toggle-reports.js
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ describe('ToggleReports', () => {
{ id: 'features' },
{ id: 'httpErrorCodes' },
{ id: 'jsPerformance' },
{ id: 'locale' },
{ id: 'openerContext' },
{ id: 'requests' },
{ id: 'userRefreshCount' },
Expand All @@ -104,6 +105,7 @@ describe('ToggleReports', () => {
{ id: 'features' },
{ id: 'httpErrorCodes' },
{ id: 'jsPerformance' },
{ id: 'locale' },
{ id: 'openerContext' },
{ id: 'requests' },
{ id: 'userRefreshCount' },
Expand Down

0 comments on commit 86fc3db

Please sign in to comment.