Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DispersiveMultiLayer no longer uses MATLAB #286

Merged
merged 10 commits into from
May 12, 2023
Merged

DispersiveMultiLayer no longer uses MATLAB #286

merged 10 commits into from
May 12, 2023

Commits on May 12, 2023

  1. Rework DispersiveMultiLayer class into a struct. TDMS builds. 

    - xyz_vector struct of 3 vector<double>s introduced
- DispersiveMultiLayer is now a struct with xyz_vector members
- Preserve method for checking if the medium is dispersive
- Temporarily disable unit tests for DispersiveMultiLayer class
- HDF5Reader::read() can now assemble a DispersiveMultiLayer
- HDF5Reader has a method for reading directly into a vector<T>
- H5Dimension can be passed a H5::DataSet as well as a H5::DataSpace
    @willGraham01 @samcunliffe
    willGraham01 authored and samcunliffe committed May 12, 2023
    Configuration menu
    Copy the full SHA
    2ce79bf View commit details
    Browse the repository at this point in the history

  2. Update paths now we need HDF5 data as well as matlab data

    @willGraham01 @samcunliffe
    willGraham01 authored and samcunliffe committed May 12, 2023
    Configuration menu
    Copy the full SHA
    821b637 View commit details
    Browse the repository at this point in the history

  3. TDMS builds and tests HDF5Reader::read_data_from_group (passes, no)

    @willGraham01 @samcunliffe
    willGraham01 authored and samcunliffe committed May 12, 2023
    Configuration menu
    Copy the full SHA
    7ae8e66 View commit details
    Browse the repository at this point in the history

  4. Fix seg-fault in read_dataset_from_group

    @willGraham01 @samcunliffe
    willGraham01 authored and samcunliffe committed May 12, 2023
    Configuration menu
    Copy the full SHA
    f1babc7 View commit details
    Browse the repository at this point in the history

  5. Add DispersiveMultiLayer test

    @willGraham01 @samcunliffe
    willGraham01 authored and samcunliffe committed May 12, 2023
    Configuration menu
    Copy the full SHA
    a1d3f28 View commit details
    Browse the repository at this point in the history

  6. Update DispersiveMultiLayer tests to not be entangled with the MATLAB… 

    … jargon
    @willGraham01 @samcunliffe
    willGraham01 authored and samcunliffe committed May 12, 2023
    Configuration menu
    Copy the full SHA
    b19f95d View commit details
    Browse the repository at this point in the history

  7. Update the CI so things actually work

    @willGraham01 @samcunliffe
    willGraham01 authored and samcunliffe committed May 12, 2023
    Configuration menu
    Copy the full SHA
    6f94870 View commit details
    Browse the repository at this point in the history

  8. Move content of benchmark_scripts readme into doc/developers

    @willGraham01 @samcunliffe
    willGraham01 authored and samcunliffe committed May 12, 2023
    Configuration menu
    Copy the full SHA
    47a0e12 View commit details
    Browse the repository at this point in the history

  9. Update CI to produce unit test .mat and .hdf5 data (#289) 

    * Move content of benchmark_scripts readme into doc/developers

* Update CI attempt 1

* Actually use the right syntax

* Force python version to prevent MacOS using python2.7

* Rename files to better match the data they produce

* Aplease windows syntax

* Remove pip cache due to known windows bug: actions/setup-python#436
    @willGraham01 @samcunliffe
    willGraham01 authored and samcunliffe committed May 12, 2023
    Configuration menu
    Copy the full SHA
    7be30ef View commit details
    Browse the repository at this point in the history

  10. Apply suggestions from code review

    @willGraham01 @samcunliffe
    willGraham01 authored and samcunliffe committed May 12, 2023
    Configuration menu
    Copy the full SHA
    d4d0cfd View commit details
    Browse the repository at this point in the history