Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bash script to reencode videos #31

Merged
merged 10 commits into from
Nov 20, 2023
Merged

Bash script to reencode videos #31

merged 10 commits into from
Nov 20, 2023

Conversation

sfmig
Copy link
Collaborator

@sfmig sfmig commented Aug 17, 2023 •
edited
Loading

Adding a bash script to reencode videos, following SLEAP guidelines

Should fix issue 14 but likely need a bit more research sadly it didn't, still looking into issue #14

@sfmig sfmig changed the title Smg/bash script reencoding Bash script to reencode videos Aug 17, 2023
@sfmig sfmig mentioned this pull request Nov 17, 2023
Merged
@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ce80381) 29.81% compared to head (abc55c2) 29.81%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main      #31   +/-   ##
=======================================
  Coverage   29.81%   29.81%           
=======================================
  Files           6        6           
  Lines         332      332           
=======================================
  Hits           99       99           
  Misses        233      233

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfmig sfmig marked this pull request as ready for review November 20, 2023 09:14
@sfmig sfmig requested review from samcunliffe and removed request for samcunliffe November 20, 2023 09:14
@sfmig sfmig requested a review from samcunliffe November 20, 2023 09:18
@sfmig sfmig mentioned this pull request Nov 20, 2023
Closed
samcunliffe
samcunliffe approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@samcunliffe samcunliffe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I like the flatter directory structure. And the less specific directory names. Or, at least, it's more to my taste.

bash_scripts/reencode_videos_sleap.sh Show resolved Hide resolved
bash_scripts/run_frame_extraction_array.sh Outdated Show resolved Hide resolved
@sfmig sfmig merged commit 224b2bd into main Nov 20, 2023
6 checks passed
@samcunliffe samcunliffe deleted the smg/bash-script-reencoding branch November 20, 2023 16:02
@sfmig sfmig linked an issue Nov 22, 2023 that may be closed by this pull request
Add SWC submission scripts to mainbranch of some version control, please 🥺 #34
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samcunliffe samcunliffe samcunliffe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add SWC submission scripts to mainbranch of some version control, please 🥺
3 participants
@sfmig @codecov-commenter @samcunliffe