Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Light refactoring #86

Merged
merged 7 commits into from
Nov 20, 2023
Merged

Light refactoring #86

merged 7 commits into from
Nov 20, 2023

Conversation

sfmig
Copy link
Collaborator

@sfmig sfmig commented Nov 17, 2023

A first chunk of light refactoring:

  • an example of avoiding long parameter list
  • reorganised the directories (moved bash scripts, guides and notebooks to the root level)

I figured we could merge to main this new structure and then I continue with closing currently open PRs.

Next steps towards that:

@codecov-commenter
Copy link

codecov-commenter commented Nov 17, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (3665608) 29.81% compared to head (13093bb) 29.81%.
Report is 1 commits behind head on main.

Files Patch % Lines
...bboxes_labelling/combine_and_format_annotations.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #86   +/-   ##
=======================================
  Coverage   29.81%   29.81%           
=======================================
  Files           6        6           
  Lines         332      332           
=======================================
  Hits           99       99           
  Misses        233      233           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfmig sfmig requested a review from samcunliffe November 17, 2023 17:58
@sfmig sfmig marked this pull request as ready for review November 17, 2023 17:58
@sfmig sfmig force-pushed the smg/light-refactoring branch from ea0c2c3 to 13093bb Compare November 17, 2023 18:03
samcunliffe

This comment was marked as outdated.

@sfmig sfmig merged commit ce80381 into main Nov 20, 2023
6 checks passed
@sfmig sfmig deleted the smg/light-refactoring branch July 15, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants