-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests for frame extraction #24
Conversation
79ba955
to
e48e1be
Compare
492f76e
to
befdc5f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good. 🫐
My comments are mostly questions. I have no substantive comments on the tests themselves.
- You're missing a few
test_flibble() -> None:
typehints. Don't know if they're important in tests but you have some typehints just not everywhere. - The file is quite long. Is there a smart way to break it up? Things that come to mind:
- Remove
Parameters
from the docstrings for tests? - Make more explicit test function names so you can do away with docstrings altogether?!
- cough longer line length cough in the linter.
- Remove
thanks for the feedback @samcunliffe!
I think it looks a bit more neat, with the caveat that now I am using the mocked app in both test cases, so in one case (the empty CLI args case) I'm unnecessarily detaching from the real use case. Let me know any thoughts! |
Integration tests for frame extraction.
Closes #15