Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MLflow logging and use .predict method from Lightning #238

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

sfmig
Copy link
Collaborator

@sfmig sfmig commented Nov 5, 2024

Description

What is this PR?

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?

What does this PR do?

  • Adds MLflow logging to detect-and-track video
  • Uses Pytorch Lightning trainer to link logger and run predict
  • Creates a videodataloader

References

Please reference any existing issues/PRs that relate to this PR.

How has this PR been tested?

Please explain how any new code has been tested, and how you have ensured that no existing functionality has changed.

Does this PR require an update to the documentation?

If any features have changed, or have been added. Please explain how the
documentation has been updated.

Checklist:

  • The code has been tested locally
  • Tests have been added to cover all new functionality
  • The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

@codecov-commenter
Copy link

codecov-commenter commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 58.33333% with 5 lines in your changes missing coverage. Please review.

Project coverage is 48.05%. Comparing base (420e0f7) to head (c375834).

Files with missing lines Patch % Lines
crabs/tracker/track_video.py 58.33% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #238      +/-   ##
==========================================
+ Coverage   47.97%   48.05%   +0.08%     
==========================================
  Files          24       24              
  Lines        1532     1544      +12     
==========================================
+ Hits          735      742       +7     
- Misses        797      802       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfmig sfmig changed the title MLflow logging and predict method Add MLflow logging and use .predict method from Lightning Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants