Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small edits to training #235

Merged
merged 8 commits into from
Nov 5, 2024
Merged

Small edits to training #235

merged 8 commits into from
Nov 5, 2024

Conversation

sfmig
Copy link
Collaborator

@sfmig sfmig commented Oct 31, 2024

Small edits to training to better match evaluation.

  • factors out logging to screen of MLflow info and datasets info
  • fixes typo in Detector class name
  • CLI arguments review: reorder them to be more consistent across evaluation and training

@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 8 lines in your changes missing coverage. Please review.

Project coverage is 48.00%. Comparing base (c992a79) to head (c9070dc).

Files with missing lines Patch % Lines
crabs/detector/train_model.py 58.33% 5 Missing ⚠️
crabs/detector/evaluate_model.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #235      +/-   ##
==========================================
+ Coverage   46.77%   48.00%   +1.23%     
==========================================
  Files          24       24              
  Lines        1520     1531      +11     
==========================================
+ Hits          711      735      +24     
+ Misses        809      796      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfmig sfmig force-pushed the smg/training-small-edits branch from a68568a to f76b7b1 Compare November 1, 2024 15:06
@sfmig sfmig marked this pull request as ready for review November 1, 2024 15:43
@sfmig sfmig force-pushed the smg/training-small-edits branch from 991f9f2 to 03264c4 Compare November 1, 2024 15:56
@sfmig sfmig force-pushed the smg/training-small-edits branch from 03264c4 to c9070dc Compare November 5, 2024 12:20
@sfmig sfmig merged commit a98b2a2 into main Nov 5, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants