Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MLflow logs to evaluate job #220

Merged
merged 19 commits into from
Nov 1, 2024
Merged

Add MLflow logs to evaluate job #220

merged 19 commits into from
Nov 1, 2024

Conversation

sfmig
Copy link
Collaborator

@sfmig sfmig commented Jul 8, 2024

What does this PR do?

  • Expands data logged in MLflow from an evaluation run
    • Adds info of the trained model being evaluated in MLflow
    • Removes option to set the evaluation job run name as a function of the training job run name (mlflow_run_name_auto is now the default behaviour)
  • Prints dataset and MLflow info to screen
  • Sets evaluation to run by default on validation split (rather than test split)
    • Adds an option to run it on the test split with a CLI flag
  • Changes name of directory with evaluation output
    • To be consistent with the tracking output
  • Updates README

@sfmig sfmig force-pushed the smg/eval-bash-script-cluster branch from efa90d0 to 285edc3 Compare July 8, 2024 17:45
@codecov-commenter
Copy link

codecov-commenter commented Jul 8, 2024

Codecov Report

Attention: Patch coverage is 11.11111% with 32 lines in your changes missing coverage. Please review.

Project coverage is 46.77%. Comparing base (7105c4c) to head (1c35f52).

Files with missing lines Patch % Lines
crabs/detector/evaluate_model.py 0.00% 25 Missing ⚠️
crabs/detector/utils/evaluate.py 12.50% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #220      +/-   ##
==========================================
- Coverage   47.69%   46.77%   -0.92%     
==========================================
  Files          24       24              
  Lines        1495     1520      +25     
==========================================
- Hits          713      711       -2     
- Misses        782      809      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfmig sfmig force-pushed the smg/eval-bash-script-cluster branch from 65d2ef0 to e110eb5 Compare October 29, 2024 17:32
@sfmig sfmig changed the title Evaluate models in the cluster Add MLflow logs to evaluate job Oct 31, 2024
@sfmig sfmig force-pushed the smg/eval-bash-script-cluster branch from a0f7f84 to ff30a86 Compare October 31, 2024 20:30
@sfmig sfmig marked this pull request as ready for review October 31, 2024 20:38
@sfmig sfmig merged commit e7a2da1 into main Nov 1, 2024
7 checks passed
@sfmig sfmig deleted the smg/eval-bash-script-cluster branch November 1, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants