Fix/support libavif v0.7.3 #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #20 +/- ##
==========================================
+ Coverage 85.27% 86.01% +0.73%
==========================================
Files 6 6
Lines 1494 1494
==========================================
+ Hits 1274 1285 +11
+ Misses 220 209 -11
Continue to review full report at Codecov.
|
|
How about releasing new version after this PR is merged? |
dreampiggy
approved these changes
May 14, 2020
|
Good work. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It may resolve #19
Some constants about colors has been renamed in libavif v0.7.3, so I replaced them.
TODO
Currently, we are discussing how should we treat ICC profile (and libavif was released with breaking changes).
In here: AOMediaCodec/av1-avif#84
So some image with ICC profile can't be decoded "correctly" now, but it looks a little difficult to resolve soon, so I left as TODO and will make an issue ( #21 ).