Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling ICC profile in another way. #21

Open
ledyba-z opened this issue May 13, 2020 · 5 comments
Open

Handling ICC profile in another way. #21

ledyba-z opened this issue May 13, 2020 · 5 comments
Assignees
Labels

Comments

@ledyba-z
Copy link
Collaborator

Split from #19, #20.

Currently, we are discussing how should we treat ICC profile while encoding/decoding.
(In here: AOMediaCodec/av1-avif#84)

After we agree about how should we do, I will rewrite the decoder and encoder according to it.

@dreampiggy
Copy link
Collaborator

dreampiggy commented May 14, 2020

@ledyba-z Can I release a patch version firstly, to fix the compile issue ?

This sounds need both libavif and SDWebImageAVIFCoder update, may be a minor version bump.

@ledyba-z
Copy link
Collaborator Author

@dreampiggy Yes, please release the new version.

This sounds need both libavif and SDWebImageAVIFCoder update, may be a minor version bump.

Yes, I think "v0.7.0" is better (However, it looks the breaking change in libavif is not released yet as v0.7.4 or v0.8.0).

@dreampiggy
Copy link
Collaborator

Seems the breaking change of profile constants was introduced during a patch version release 😅

image

libavif does not follows semversion currently. I can change that into s.dependency 'libavif', '>= 0.7.2' for this.

@dreampiggy
Copy link
Collaborator

Released v0.6.1 firstly. This compatible with libavif 0.7.2+

If libavif 0.8 or later do a huge refactory, we can bump into 0.7.0 again.

@ledyba-z
Copy link
Collaborator Author

ledyba-z commented May 14, 2020

Oh, sorry. You are right. I just saw only results of git blame 😅

libavif does not follows semversion currently. I can change that into s.dependency 'libavif', '>= 0.7.2' for this.
If libavif 0.8 or later do a huge refactory, we can bump into 0.7.0 again.

Both LGTM, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants